docs(readme): correct containerd backend flag to --containerd-address#272
Merged
AkihiroSuda merged 1 commit intoMay 11, 2026
Conversation
The explicit-enable example referenced --containerd-socket, which the binary rejects (the flag does not exist). The actual flag registered in cmd/diffoci/backend/containerdbackend/containerdbackend.go is --containerd-address, bound to the CONTAINERD_ADDRESS env var. Fixes reproducible-containers#265 Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265
Summary
The "explicit enable containerd" example in
README.mdreferenced--containerd-socket, which the binary rejects:Looking at
cmd/diffoci/backend/containerdbackend/containerdbackend.go, the flag registered on the containerd backend is--containerd-address(bound toCONTAINERD_ADDRESS).--containerd-socketdoes not exist.Change
README.md: update the example to use--containerd-address=ADDRESS, matching the actual flag name.--containerd-namespacewas already correct.Testing
Grepped the full tree (
grep -rn "containerd-socket\|containerd-address") - the only remainingcontainerd-socketreference was in this README line; the flag registration, getter, and every other mention usescontainerd-address.DCO signoff included.