include lineage flag on support gems#60
Open
tskimmett wants to merge 2 commits into
Open
Conversation
tskimmett
changed the title
tskimmett
changed the title
tskimmett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Projected
SupportGems.dat64.IsLineageinto support gem JSON asis_lineage.Refactored support gem parsing so
convert_gemreceives the matchedSupportGemsrow directly, which now provides both icon and lineage metadata.Why
Lineage support gems were not being explicitly represented in parsed skill gem data, which forced downstream consumers to infer lineage status from tags (apparently they aren't all tagged appropriately). This change preserves the source-of-truth lineage flag from the DAT layer.
I did notice what appears to be an issue in the source data where several supports for persistent buffs are incorrectly marked as lineage 🤷