ci: remove pull_request_target trigger from release-drafter#377
Open
ryantm wants to merge 1 commit into
Open
Conversation
Eliminates exposure of the supply-chain-attack pattern demonstrated by the TanStack NPM compromise. The release-drafter workflow never checks out PR head code, so the current usage isn't immediately exploitable, but we're removing pull_request_target from all Replit-owned public repos as a precaution. Side-effect: autolabeler will no longer run on PRs from forks. Release notes are still drafted on pushes/merges to main, so the only impact is that fork PRs won't get autolabeled until merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TanStack NPM supply-chain compromise (postmortem) exploited a
pull_request_targetworkflow. Per security policy, we're removingpull_request_targetfrom all Replit-owned public repos as a precaution.This workflow's current usage isn't immediately exploitable — it only runs the release-drafter action and never checks out PR head code — but the trust boundary is fragile and we'd rather not have any
pull_request_targetin public repos.Slack thread: https://replit.slack.com/archives/C03FS477T17/p1778588219046429
What changed
Removed the
pull_request_targettrigger block from.github/workflows/release-drafter.yml. Theworkflow_dispatch,push, andpull_requesttriggers all stay.Side-effect: autolabeler will no longer run on PRs from forks. Release notes are still drafted on pushes/merges to
main, so the only impact is that fork PRs won't get autolabeled until merged.Versioning
Revertibility
Safe to revert — single-file CI workflow change with no runtime, data, or protocol impact.
~ written by Zerg 👾 (warped-guardian-042e)