chore/quality #142
Merged
chore/quality #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
force-pushed
the
dstewart/chore/quality
branch
from
852a0f8 to
101010b
Compare
ryantm
approved these changes
Mar 14, 2025
blast-hardcheese
force-pushed
the
dstewart/chore/quality
branch
4 times, most recently
from
965942d to
ebb90c7
Compare
blast-hardcheese
force-pushed
the
dstewart/chore/quality
branch
from
ebb90c7 to
d71b0cf
Compare
blast-hardcheese
force-pushed
the
dstewart/chore/quality
branch
from
d71b0cf to
652a176
Compare
blast-hardcheese
added a commit
that referenced
this pull request
Mar 18, 2025
Why === Introduced in #142, `NotRequired[A] | None` doesn't typecheck, but we didn't have any codegen tests that exhausted that path. What changed ============ Move the statically rendered `${render(...)} | None` into `${render(UnionTypeExpr([..., NoneTypeExpr()]))}` so the type renderer knows about and can properly unify/deduplicate/render the structured union. Test plan ========= TODO: Add a test that makes it so we don't regress here in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We had a number of long-standing nice-to-haves, let's just do them
What changed
Dict/List/Tuple/Optionalthe builtin types. Let's do that.lambdatodeffor readability and maintainabilityis_literal# noqato remove the need forsedin our generator scriptsTest plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it