[bug] Forgot type render call #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested review from
jackyzha0
and removed request for
a team
lhchavez
approved these changes
Feb 15, 2025
blast-hardcheese
force-pushed
the
dstewart/bug/forgot-type-render
branch
from
2a8e36d to
a92d2be
Compare
blast-hardcheese
force-pushed
the
dstewart/bug/forgot-type-render
branch
from
a92d2be to
783ea2e
Compare
blast-hardcheese
added a commit
that referenced
this pull request
Feb 15, 2025
Why === In an attempt at good quality-of-life tooling, I optimistically added a `lint` command, invoked via `uv run lint`. I thought since I wasn't shipping the `lint.py` I was safe, but it turns out I was shipping the entrypoints via the package META. What changed ============ - Convert `lint.py` into a proper local package, scoped to `[dev]` - Fix two incorrect comparisons. Test plan ========= _Describe what you did to test this change to a level of detail that allows your reviewer to test it_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Ended up leaking a raw
TypeExpressioninto generated code by forgetting this render call.Also made the rest of these dataclasses throw when used incorrectly.
What changed
Test plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it