[client codegen] Unknown enumeration values, attempt 2 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
While technically the previously emitted deserializers were functional, the ergonomics were basically unusable. I fixed the local development flow so I could complete the whole feature end-to-end this time, confirming that it works.
What changed
RiverUnknownValue, emitted via a newly exposedraise_unknownIt would be preferred to have had the
Annotated[...]directly on underlying models instead of leaking the unknown status into the top-level enumerations, but that was going to require more surgery.The client migration from this encoding to that encoding will be very easy.
Test plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it