Fix accidental truncation of RPC timeouts #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current dependencies on/for this PR: This comment was autogenerated by Freephite. |
cbrewster
requested review from
blast-hardcheese and
ryantm
and removed request for
a team
blast-hardcheese
approved these changes
Dec 10, 2024
Contributor
blast-hardcheese
left a comment
blast-hardcheese
left a comment
There was a problem hiding this comment.
"Why do we cast to int here?"
To make finding the bug much more interesting
cbrewster
deleted the
12-10-Fix_accidental_truncation_of_RPC_timeouts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
asyncio.timeouttakes afloatin units of seconds. We were truncating to anintso for example a200mstimeout would be converted to0sWhat changed
int()Test plan