Skip to content

Conversation

@blast-hardcheese
Copy link
Contributor

Why

Striking a balance between test handler reuse and colocating the handler specifiers with the tests that use them.

What changed

  • Decomposing monolithic server handler specifiers into directly DI-ing reusable components
  • For tests that need bespoke handlers, defining those alongside the methods that use them.

Test plan

CI

@blast-hardcheese blast-hardcheese marked this pull request as ready for review November 28, 2024 19:41
@blast-hardcheese blast-hardcheese requested a review from a team as a code owner November 28, 2024 19:41
@blast-hardcheese blast-hardcheese requested review from cbrewster and ryantm and removed request for a team November 28, 2024 19:41
@blast-hardcheese
Copy link
Contributor Author

@cbrewster Following up on an earlier PR comment. This brings handler invocation closer to the tests that use them.

Copy link
Member

@cbrewster cbrewster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like it

@blast-hardcheese blast-hardcheese merged commit 502278f into main Nov 28, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/handler-decomposition branch November 28, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants