Make optional input fields NotRequired #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
cbrewster
force-pushed
the
11-27-Make_optional_input_fields_NotRequired
branch
2 times, most recently
from
4e8ba4f to
756c556
Compare
cbrewster
force-pushed
the
11-27-Make_optional_input_fields_NotRequired
branch
from
756c556 to
7efabc8
Compare
Member
Author
|
Getting back to this, I had to fix a couple other things in the codegen, but this should work now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
River does not distinguish between
Noneand unset, its nice to not have to manually specifyNoneeverywhere.What changed
NotRequiredTest plan
NotRequiredand they should not be required