Implement RPC timeouts #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
force-pushed
the
dstewart/feat/rpc-timeouts
branch
8 times, most recently
from
4c4006b to
f09fda5
Compare
blast-hardcheese
requested review from
jackyzha0
and removed request for
a team
jackyzha0
approved these changes
Dec 2, 2024
Merged
blast-hardcheese
added a commit
that referenced
this pull request
Dec 2, 2024
Why === Breaking out ruff changes from #123 What changed ============ Separation of concerns, increasing revertability Test plan ========= CI
blast-hardcheese
force-pushed
the
dstewart/feat/rpc-timeouts
branch
from
2ad4ca5 to
187a487
Compare
blast-hardcheese
force-pushed
the
dstewart/feat/rpc-timeouts
branch
from
a261b7b to
f5de68b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Requiring an explicit timeout to be set on all RPC calls will prevent runaway execution.
What changed
Add a required
timeout: timedeltaparameter to all rpc methodsTest plan
TBD. https://github.com/replit/river-babel would be nice for this, but it's still undergoing some upgrade pains.