Skip to content

Conversation

@blast-hardcheese
Copy link
Contributor

Why

None of these changes impact production codepaths, so we've presumably been skating by without issue up until now, but let's make sure we don't run into trouble in the future.

What changed

  • f"x: '{foo}' -> f"x: {repr(foo)}". If it's a string, it'll be a no-op. If it's not, it'll be an error.
  • RiverNotType has never worked. Rip it out.
  • Address incorrect init vs input bindings
  • The result type of transport messages will be None in the case where the whole function also should return None, so remove some confusing metaprogramming about optional return statements.

Test plan

Describe what you did to test this change to a level of detail that allows your reviewer to test it

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner November 21, 2024 22:03
@blast-hardcheese blast-hardcheese requested review from jackyzha0 and removed request for a team November 21, 2024 22:03
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) November 21, 2024 22:06
@blast-hardcheese blast-hardcheese added the bug Something isn't working label Nov 21, 2024
@blast-hardcheese blast-hardcheese merged commit cafcc18 into main Nov 21, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/minor-oddities branch November 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants