Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
None of these changes impact production codepaths, so we've presumably been skating by without issue up until now, but let's make sure we don't run into trouble in the future.
What changed
f"x: '{foo}'->f"x: {repr(foo)}". If it's a string, it'll be a no-op. If it's not, it'll be an error.RiverNotTypehas never worked. Rip it out.initvsinputbindingsNonein the case where the whole function also should returnNone, so remove some confusing metaprogramming about optionalreturnstatements.Test plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it