fix: use atomic rename in setup_subprocess_double_fork test#2815
Open
fix: use atomic rename in setup_subprocess_double_fork test#2815
Conversation
…t race condition The forked child process writes .outbox directly, which means the predictor can observe the file (via os.path.exists) before the content is fully flushed. Write to .outbox.tmp first, then os.rename() to .outbox so the predictor never reads a partially-written file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup_subprocess_double_forkintegration test that causes flaky CI failures.outboxdirectly, allowing the predictor to observe the file (viaos.path.exists) before content was fully flushed — resulting in"output":""instead of the expected value.outbox.tmpfirst, thenos.rename()to.outbox, so the predictor never reads a partially-written file