Add a ton more Autorelease Pools#95
Closed
IsaacMarovitz wants to merge 1 commit into
Closed
Conversation
squidbus
reviewed
May 19, 2026
IsaacMarovitz
force-pushed
the
kitchen-sink
branch
2 times, most recently
from
73214c1 to
bd3bc78
Compare
Leaker no leaking
IsaacMarovitz
force-pushed
the
kitchen-sink
branch
from
bd3bc78 to
d103d70
Compare
squidbus
reviewed
May 19, 2026
| @@ -1198,6 +1212,7 @@ namespace plume { | |||
| this->texture = buffer->mtl->newTexture(descriptor, 0, bytesPerRow); | |||
|
|
|||
| descriptor->release(); | |||
Contributor
There was a problem hiding this comment.
I'm not 100% sure but this might not need to be released since textureBufferDescriptor is not alloc/new/copy?
| NS::AutoreleasePool *releasePool = NS::AutoreleasePool::alloc()->init(); | ||
|
|
||
| this->format = format; | ||
| this->functionName = (entryPointName != nullptr) ? NS::String::string(entryPointName, NS::UTF8StringEncoding) : MTLSTR(""); |
Contributor
There was a problem hiding this comment.
This might need retain for the NS::String::string.
| if (debugName) { | ||
| debugName->release(); | ||
| } | ||
| debugName = NS::String::string(name.c_str(), NS::UTF8StringEncoding); |
Contributor
There was a problem hiding this comment.
Same here, might need to retain this since we keep it.
Contributor
|
Superseded by #97. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve or at least make the leaks much slower.