Skip to content

refactor(onboarding-invite) - use new mutation method#757

Merged
gabrielseco merged 6 commits intomainfrom
refactor-onboarding-invite-before-reserve-invoice
Feb 27, 2026
Merged

refactor(onboarding-invite) - use new mutation method#757
gabrielseco merged 6 commits intomainfrom
refactor-onboarding-invite-before-reserve-invoice

Conversation

@gabrielseco
Copy link
Collaborator

@gabrielseco gabrielseco commented Feb 25, 2026

Use new mutation method to handle errors and move fixtures


Note

Medium Risk
Moderate risk because it changes how invite mutation errors propagate/are shaped (throwing vs returning), which could alter UI error handling and tests if any callers relied on the old response-based branching.

Overview
Refactors OnboardingInvite to use mutationToPromise(...).mutateAsyncOrThrow, simplifying the invite flow to assume success data is returned and handling failures via thrown structured errors (with response stripped before calling onError).

Moves the contractor basic-information JSON schema fixture out of flow test fixtures into src/common/api/fixtures/contractors.ts, and updates MSW test handlers to serve contractor_basic_information globally (removing per-test mocks and trimming onboarding tests accordingly).

Written by Cursor Bugbot for commit 74e71a0. This will update automatically on new commits. Configure here.

@gabrielseco gabrielseco self-assigned this Feb 25, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 199.62 kB 199.48 kB +133 B (+0.1%) 🔴
Total (raw) 529.85 kB 529.79 kB +59 B (+0.0%) 🔴
CSS (gzip) 19.37 kB 19.37 kB 0 B (0%) 🟢
CSS (raw) 101.83 kB 101.83 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 199.62 kB / 200 kB (99.8%)
  • ✅ Total raw: 529.85 kB / 550 kB (96.3%)
  • ✅ CSS gzipped: 19.37 kB / 25 kB (77.5%)

Largest Files (Top 5)

  1. chunk-H2JFQGQJ.js - 12.43 kB (new)
  2. styles.css - 9.69 kB (0 B (0%))
  3. index.css - 9.69 kB (0 B (0%))
  4. index.js - 6.06 kB (-2 B (-0.0%))
  5. chunk-7ENB7H4E.js - 5.73 kB (0 B (0%))
View All Files (312 total)
File Size (gzip) Change
chunk-H2JFQGQJ.js 12.43 kB new
styles.css 9.69 kB 0 B (0%)
index.css 9.69 kB 0 B (0%)
index.js 6.06 kB -2 B (-0.0%)
chunk-7ENB7H4E.js 5.73 kB 0 B (0%)
chunk-3B6XXK5H.js 4.07 kB new
chunk-2NDVHQRP.js 4.02 kB new
chunk-T7O3YYOG.js 3.29 kB 0 B (0%)
chunk-FJVQQ4XB.js 3.29 kB new
chunk-QECFSTI4.js 3.21 kB new

✅ Bundle size check passed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Deploy preview for remote-flows ready!

✅ Preview
https://remote-flows-m5wmwldic-remotecom.vercel.app

Built with commit 6718f46.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Deploy preview for remote-flows-example-app ready!

✅ Preview
https://remote-flows-example-mvfk88kup-remotecom.vercel.app

Built with commit 6718f46.
This pull request is being automatically deployed with vercel-action

@gabrielseco
Copy link
Collaborator Author

bugbot run

@cursor
Copy link

cursor bot commented Feb 25, 2026

Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

npm warn exec The following package was not found and will be installed: tsx@4.21.0

📊 Coverage Report

⚠️ Coverage decreased

Metric Current Previous Change Status
Lines 88.66% 88.66% 0%
Statements 88.32% 88.32% 0%
Functions 84.78% 84.78% 0%
Branches 79.29% 79.30% -0.02% 🔴

Detailed Breakdown

Lines Coverage
  • Covered: 3346 / 3774
  • Coverage: 88.66%
  • Change: 0% (-1 lines)
Statements Coverage
  • Covered: 3403 / 3853
  • Coverage: 88.32%
  • Change: 0% (-1 statements)
Functions Coverage
  • Covered: 936 / 1104
  • Coverage: 84.78%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2109 / 2660
  • Coverage: 79.29%
  • Change: -0.02% (-2 branches)

✅ Coverage check passed

@gabrielseco
Copy link
Collaborator Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@gabrielseco gabrielseco merged commit e43144a into main Feb 27, 2026
6 checks passed
@gabrielseco gabrielseco deleted the refactor-onboarding-invite-before-reserve-invoice branch February 27, 2026 14:12
This was referenced Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants