fix(contractor-onboarding) - fix maxDate for contractor of record#1042
Open
gabrielseco wants to merge 7 commits into
Open
fix(contractor-onboarding) - fix maxDate for contractor of record#1042gabrielseco wants to merge 7 commits into
gabrielseco wants to merge 7 commits into
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (312 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7152bc5. Configure here.
gabrielseco
commented
May 20, 2026
| field = { | ||
| ...field, | ||
| ...(field.calculateDynamicProperties(watchedValues, field) || | ||
| ...(field.calculateDynamicProperties(allFormValues, field) || |
Collaborator
Author
There was a problem hiding this comment.
without this the calculateDynamicProperties that we use in jsfModify doesn't work correctly
gabrielseco
commented
May 20, 2026
| inputType: 'date', | ||
| meta: { | ||
| mot: 20, | ||
| mot: 0, |
Collaborator
Author
There was a problem hiding this comment.
as I added minDates to the datepicker mocked, this is needed, mot in other fixtures is also 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a maxDate to the service_duration.expirationDate when the product selected is contractor of record
https://www.loom.com/share/7d7c49eb8c9c445db4f7b8d2abb4c3e5
Note
Medium Risk
Touches dynamic form field evaluation (
watch()/calculateDynamicProperties) and date handling, which can affect validation/render performance and date constraints across forms. Scoped to contractor onboarding and test components, but regressions could impact date pickers and dynamic field props.Overview
Adds a COR-specific constraint in contractor onboarding so
service_duration.expiration_datedynamically gets amaxDateset to 12 months afterservice_duration.provisional_start_date(usingparseLocalDateto avoid timezone day-shifts).Updates
FieldSetFieldto pass full form values intocalculateDynamicPropertieswhen needed (instead of only the fieldset’s watched values), and updates the testdatecomponent to actually applymin/maxattributes fromminDate/maxDate. Includes new onboarding tests covering COR vs non-COR max-date behavior, plus a small fixture tweak (mot: 20→0).Reviewed by Cursor Bugbot for commit ee9933f. Bugbot is set up for automated code reviews on this repo. Configure here.