docs(onboarding) - add e2e happy path#1010
Open
jordividaller wants to merge 27 commits into
Open
Conversation
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
gabrielseco
reviewed
May 14, 2026
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (312 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
jordividaller
commented
May 18, 2026
Collaborator
|
bugbot run |
Bugbot couldn't runBugbot is not enabled for your user on this team. Ask your team administrator to increase your team's hard limit for Bugbot seats or add you to the allowlist in the Cursor dashboard. |
Contributor
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
gabrielseco
requested changes
May 18, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b898261. Configure here.
jordividaller
changed the title
gabrielseco
reviewed
May 20, 2026
| dataField?: string, | ||
| ) { | ||
| if (cssId) { | ||
| if (value) { |
| options: Partial<fillOnboardingIntroductionFormOptions>, | ||
| ) { | ||
| await fillForm(page, [ | ||
| { type: 'textField', value: options.company_id, cssId: '#companyId' }, |
Collaborator
There was a problem hiding this comment.
I think we can simplify the API to only query by the same attribute can you check this PR #1041
To see the changes I propose
I believe we'll simplify the API and don't mix ids like '#companyId' and dataField
| "arm64" | ||
| ], | ||
| "dev": true, | ||
| "libc": [ |
added 16 commits
May 22, 2026 15:06
…e onboarding test
jordividaller
force-pushed
the
test/pbyr-3802-e2e-oboarding-scenario
branch
from
8e8d4f5 to
ce8244e
Compare
gabrielseco
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[https://linear.app/remote/issue/PBYR-3802/extend-e2e-tests-to-cover-eor-onboarding-scenario]
I've decided to split helpers to avoid having a file that's too large in the future.
All my form-filling functions can accept different parameters to allow them to be used for futures tests (tlike testing errors scenarios for example).
Note
Low Risk
Low risk: changes are confined to
example/E2E test code and adds non-functionaldata-*attributes for selectors; no library runtime or API behavior is modified.Overview
Adds a new Playwright E2E spec that runs a full happy-path through the
onboarding-basicdemo (intro + country selection + basic info + contract details + benefits + review) using reusable form-filling helpers.Refactors E2E helpers by splitting Vercel bypass routing and generic form input utilities into
helpers/general.ts, moving estimation helpers tohelpers/estimation.ts, and updating existing cost-calculator specs to import from the new locations. The example onboarding page is updated withdata-testid/data-fieldattributes to make selectors stable for the new tests, and a newCLAUDE.mdis added with repository contribution guidance.Reviewed by Cursor Bugbot for commit ce8244e. Bugbot is set up for automated code reviews on this repo. Configure here.