feat(review-step) - if initiated move to review step#1003
feat(review-step) - if initiated move to review step#1003gabrielseco wants to merge 1 commit intomainfrom
Conversation
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (312 total)
✅ Bundle size check passed |
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b9a8ef0. Configure here.
| * @constant | ||
| */ | ||
| export const reviewStepAllowedEmploymentStatus: Employment['status'][] = [ | ||
| 'initiated', |
There was a problem hiding this comment.
Infinite loading state when initiated employment lacks contract documents
High Severity
Adding 'initiated' to reviewStepAllowedEmploymentStatus in the ContractorOnboarding flow can cause a permanent loading state. The isNavigatingToReview check in hooks.tsx requires internalContractDocumentId to be truthy, but an initiated employment (meaning onboarding has merely been started by the employer) may not yet have contract documents. When that happens, shouldHandleReadOnlyEmployment stays true while isNavigatingToReview stays false, so isLoading never resolves and goToStep('review') is never called — the user is stuck on a spinner indefinitely.
Reviewed by Cursor Bugbot for commit b9a8ef0. Configure here.


Note
Medium Risk
Changes step-gating logic so
initiatedemployments become read-only and can auto-navigate to thereviewstep, which may alter onboarding progression for existing in-flight records.Overview
Allows employments in
initiatedstatus to be treated as review-step eligible in both the employee onboarding and contractor onboarding flows.This updates the status lists used to determine read-only behavior and to disable the invite button, so
initiatednow triggers the same review-step navigation/locking behavior as other finalized statuses.Reviewed by Cursor Bugbot for commit b9a8ef0. Bugbot is set up for automated code reviews on this repo. Configure here.