Skip to content

feat: Add ci.skip push option to mob next #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heidiberry wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add ci.skip push option to mob next #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0993210
feat: Add ci.skip push option to next
heidiberry Feb 20, 2026
1ea6f4b
Update mob.go
heidiberry Feb 20, 2026
d295878
Update mob_test.go
heidiberry Feb 20, 2026
8e33771
Update mob_test.go
heidiberry Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,13 +790,13 @@ func next(configuration config.Configuration) {

if isNothingToCommit() {
if currentWipBranch.hasLocalCommits(configuration) {
gitWithoutEmptyStrings("push", gitHooksOption(configuration), configuration.RemoteName, currentWipBranch.Name)
gitWithoutEmptyStrings(append(gitPushArgs(configuration), gitHooksOption(configuration), configuration.RemoteName, currentWipBranch.Name)...)
} else {
say.Info("nothing was done, so nothing to commit")
}
} else {
makeWipCommit(configuration)
gitWithoutEmptyStrings("push", gitHooksOption(configuration), configuration.RemoteName, currentWipBranch.Name)
gitWithoutEmptyStrings(append(gitPushArgs(configuration), gitHooksOption(configuration), configuration.RemoteName, currentWipBranch.Name)...)
}
showNext(configuration)

Expand Down
51 changes: 51 additions & 0 deletions mob_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,58 @@ func TestStartWithOutCISkip(t *testing.T) {
assertMobSessionBranches(t, configuration, "mob-session")
assertCommitLogNotContainsMessage(t, "mob-session", configuration.StartCommitMessage)
assertOutputNotContains(t, output, "--push-option ci.skip")
}

func TestNextWithCISkipLocalCommits(t *testing.T) {
output, configuration := setup(t)
configuration.SkipCiPushOptionEnabled = true
mockExit()

start(configuration)
createFileAndCommitIt(t, "example.txt", "asdf", "asdf")
next(configuration)

assertOutputContains(t, output, "git push --push-option ci.skip")
assertOutputContains(t, output, "Disable the push option ci.skip in your .mob file or set the expected environment variable")
assertOutputContains(t, output, "export MOB_SKIP_CI_PUSH_OPTION_ENABLED=false")
resetExit()
}

func TestNextWithOutCISkipLocalCommits(t *testing.T) {
output, configuration := setup(t)
configuration.SkipCiPushOptionEnabled = false

start(configuration)
createFileAndCommitIt(t, "example.txt", "asdf", "asdf")
next(configuration)

assertOutputNotContains(t, output, "--push-option ci.skip")
}

func TestNextWithCISkipSomethingToCommit(t *testing.T) {
output, configuration := setup(t)
configuration.SkipCiPushOptionEnabled = true
mockExit()

start(configuration)
createFile(t, "example.txt", "contentIrrelevant")
next(configuration)

assertOutputContains(t, output, "git push --push-option ci.skip")
assertOutputContains(t, output, "Disable the push option ci.skip in your .mob file or set the expected environment variable")
assertOutputContains(t, output, "export MOB_SKIP_CI_PUSH_OPTION_ENABLED=false")
resetExit()
}

func TestNextWithOutCISkipSomethingToCommit(t *testing.T) {
output, configuration := setup(t)
configuration.SkipCiPushOptionEnabled = false

start(configuration)
createFile(t, "example.txt", "contentIrrelevant")
next(configuration)

assertOutputNotContains(t, output, "--push-option ci.skip")
}

func TestStartWithMultipleExistingBranches(t *testing.T) {
Expand Down