Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Welcome @karlhorky 👋 |
|
To your CI/CD comment, I think |
I'm sorry. Was definitely not my intention to cause any stress or be aggressive and I'd like to understand more to improve. I'll try reaching out privately on Twitter/X/email. |
Added a step in 0607f10 (Made it a separate step to make it easier to delete later, with less noise in Git blame) |
|
Glad to see see again @karlhorky! The changes look good to me. |
|
Glad to help, thanks for the reviews! If there's anything else I should do to get this merged, let me know :) |
Initial checklist
Description of changes
It looks like #18 used the
UseRemarkOptionstype instead of theUseRemarkSyncOptionstype for the 2nd parameter of theuseRemarkSync()function:It seems incorrect to me because of A) the name and B) the
onErrorproperty not being used.