Add a git-snapshot (tarball) generator#72
Add a git-snapshot (tarball) generator#72praiskup wants to merge 2 commits intorelease-engineering:mainfrom
Conversation
|
@praiskup The OpenScanHub task submitted for this pull request seems to introduce shellcheck warnings: https://openscanhub.fedoraproject.org/task/25262/ Shall those files be packaged with the sources? |
Are those issues really new? Seems like some csdiff mismatch. |
For some reason, these warnings do not show up in the base scan: https://openscanhub.fedoraproject.org/task/25265/log/stdout.log And it happened a couple of times. Previous scan can be seen at https://openscanhub.fedoraproject.org/task/25254/ |
|
Isn't it because we did a rather non-trivial code movement within this repository recently aae2272? |
|
@praiskup It actually happened because Packit is submitting multiple scans for @lbarcziova It looks like another bug in Packit. |
FrostyX
left a comment
FrostyX
left a comment
There was a problem hiding this comment.
I didn't try to run this yet, ... only a first quick review.
| _, distgit_instance_config = get_distgit_config(config, args.forked_from) | ||
| spec = _get_preprocessed_specfile(distgit_instance_config, args) | ||
|
|
||
| with tempfile.TemporaryDirectory(prefix="copr-test-walk") as workdir: |
There was a problem hiding this comment.
We should probably not use "copr" in the prefix
| elif args.action == "clone": | ||
| clone(args, config) | ||
| elif args.action == "snapshot": | ||
| snapshot(args, config) |
There was a problem hiding this comment.
Bikeshedding ... not sure if we should call this feature "snahpshot", or maybe "archive", or something else.
The src.rpm is distribution-specific format; the `rpmbuild -bs` doesn't necessarily generate the same output SRC.RPM if run on different distributions. The `snapshot` tarball is though generated in a distribution-agnostic way. Note that this tarball generator still requires specfile parsing by RPM, and it may fail easily, see release-engineering#71 for more info.
praiskup
force-pushed
the
praiskup-dist-git-tarball
branch
from
2283ea9 to
01f9ed1
Compare
3 participants
The src.rpm is distribution-specific format; the
rpmbuild -bsdoesn't necessarily generate the same output SRC.RPM if run on different distributions. Thesnapshottarball is though generated in a distribution-agnostic way.Note that this tarball generator still requires specfile parsing by RPM, and it may fail easily, see #71 for more info.