-
Notifications
You must be signed in to change notification settings - Fork 123
[docs] Update ReFrame tutorial containers #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vkarak
wants to merge
1
commit into
reframe-hpc:develop
Choose a base branch
from
vkarak:docs/update-tut-containers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,31 @@ | ||
| FROM ubuntu:22.04 | ||
| FROM ubuntu:24.04 | ||
| COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /usr/local/bin/ | ||
|
|
||
| RUN apt-get -y update && \ | ||
| apt-get -y install curl && \ | ||
| apt-get -y install sudo && \ | ||
| apt-get -y install python3-pip && \ | ||
| apt-get -y install clang gcc git jq libomp-dev tree vim | ||
|
|
||
| # Install reframe | ||
| ARG REFRAME_TAG=develop | ||
| ARG REFRAME_REPO=reframe-hpc | ||
| WORKDIR /usr/local/share | ||
|
|
||
| # Clone reframe | ||
| # RUN git clone --depth 1 --branch $REFRAME_TAG https://github.com/$REFRAME_REPO/reframe.git && \ | ||
| # cd reframe/ && ./bootstrap.sh | ||
|
|
||
| # Comment the above line and uncomment the following two for development | ||
|
|
||
| COPY . /usr/local/share/reframe | ||
| RUN cd reframe && ./bootstrap.sh | ||
|
|
||
| ENV PATH=/usr/local/share/reframe/bin:$PATH | ||
|
|
||
| # Install stream | ||
| WORKDIR /usr/local/share | ||
| RUN mkdir -p stream/bin && \ | ||
| cd stream && \ | ||
| curl -fsSLJO https://www.cs.virginia.edu/stream/FTP/Code/stream.c && \ | ||
| gcc -DSTREAM_ARRAY_SIZE=100000000 -O3 -Wall -fopenmp -o bin/stream.x stream.c | ||
| ENV PATH=/usr/local/share/stream/bin:$PATH | ||
|
|
||
| # Prepare reframe installation | ||
| WORKDIR /workspace | ||
| COPY . /workspace/reframe | ||
|
|
||
| # Add tutorial user | ||
| RUN useradd -ms /bin/bash -G sudo user && \ | ||
| echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers | ||
|
|
||
| # COPY examples /home/user/reframe-examples | ||
| # RUN chown -R user:user /home/user/reframe-examples | ||
| WORKDIR /home/user | ||
|
|
||
| # Install reframe | ||
| USER user | ||
| RUN uv tool install /workspace/reframe | ||
| ENV PATH=/home/user/.local/bin:$PATH | ||
| ENV MANPATH=/home/user/.local/share/uv/tools/reframe-hpc/share/man | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be with a
:in the end, right? And also maybe add an end line?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because so as to append to the system's man page path, which is not set by MANPATH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right; I misread the comment; thought you were suggesting to remove the
:, but you are actually pointing out that it is missing. Thanks, I'll fix it!