Conversation
This was referenced Aug 3, 2024
Member
|
Partly rendered obsolete by #56, but not entirely. |
Ericson2314
added a commit
that referenced
this pull request
Sep 12, 2024
1. Restore a `Data.Semigroup.Commutative` reexport accidentally removed in #56. (I accidentally forgot to notice during review.) 2. Replace partial `Map.lookup` with proper custom error for internal error. (This would make debugging a bug in the implementation easier.) This was part of #55. Co-Authoredy-By: Dmitry Olshansky <olshanskydr@gmail.com>
Ericson2314
force-pushed
the
develop
branch
from
e48ce5f to
c0ac897
Compare
Member
|
Rebased, now just CI changes |
Ericson2314
changed the title
Ericson2314
reviewed
Sep 26, 2024
| name: GHC ${{ matrix.ghc }} on ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: haskell/actions/setup@v2 |
Member
There was a problem hiding this comment.
haskell/actions
OK yes that repo is deprecated, I just learned. This helps me understand why these changes.
Author
There was a problem hiding this comment.
My main goal was compiling with javascript-backend. I think that #56 do it so I am OK to close...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.