Skip to content

[ENG-5520] admin dashboard from flexgen #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kastier1 merged 17 commits into from
Apr 23, 2025
Merged

[ENG-5520] admin dashboard from flexgen #65

Kastier1 merged 17 commits into from
Apr 23, 2025

Conversation

@LineIndent
Copy link
Contributor

@LineIndent LineIndent commented Apr 16, 2025

No description provided.

@linear
Copy link

linear bot commented Apr 16, 2025

ENG-5520 Admin Panel Template

@LineIndent LineIndent requested a review from Alek99 April 16, 2025 12:40
Alek99
Alek99 requested changes Apr 16, 2025
View reviewed changes
Alek99
Alek99 previously requested changes Apr 16, 2025
View reviewed changes
@Kastier1
Copy link
Contributor

Kastier1 commented Apr 22, 2025

Two things:

  • When you search / filter in the table after it does the filter it deselects from the input box. After I type i should stay focused on the input
  • I should be able to order the table from the column headers

@Kastier1 Kastier1 requested review from Alek99 and Kastier1 April 22, 2025 22:30
Kastier1
Kastier1 requested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@Kastier1 Kastier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@LineIndent
Copy link
Contributor Author

LineIndent commented Apr 23, 2025

  1. search bar doesn't loose focus
  2. applicable columns can be sorted

@Kastier1
Copy link
Contributor

Kastier1 commented Apr 23, 2025

Customer name , Industry and Platform cant be sorted

Also the sorted icons are slightly different
image
image

@Kastier1 Kastier1 merged commit a12fae5 into main Apr 23, 2025
16 checks passed
@Kastier1 Kastier1 deleted the ahmad/admin-dashboard branch April 23, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kastier1 Kastier1 Kastier1 approved these changes

@Alek99 Alek99 Awaiting requested review from Alek99

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LineIndent @Kastier1 @Alek99