[ENG-5878] weather app template #103
Conversation
masenf
left a comment
masenf
left a comment
There was a problem hiding this comment.
can you deploy the app so we can test
| { | ||
| "name": "weatherstack_app", | ||
| "description": "A minimal weather app", | ||
| "demo_url": "https://company-dashboard-navy-book.reflex.run/", |
There was a problem hiding this comment.
need to make sure this is updated after deploying the app
There was a problem hiding this comment.
yup will change this today after re-deploy
| "access_key": self.api_key, | ||
| "query": self.city, | ||
| } | ||
| response = requests.get(WEATHERSTACK_API_URL, params=params) |
There was a problem hiding this comment.
using a blocking call here is not ideal as it will block other users on the server until the request completes, if this request is slow (and note it has no timeout), the app performance could degrade across all users.
There was a problem hiding this comment.
I changed this using httpx - I should point out this was entirely generated from the AI (I did not change the backend) so maybe something we need to look at for future generations if this kind of blocking good is not good practice
|
Seems like this is not passing CI |
|
PR #111 |
No description provided.