Skip to content

Conversation

@adhami3310
Copy link
Member

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #6059 will not alter performance

Comparing publish-job (be1210e) with main (2175b3b)

Summary

✅ 8 untouched

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 19, 2025

Greptile Summary

Adds a new GitHub Actions workflow for publishing the Reflex package to PyPI using uv and trusted publishing (OIDC).

Key Changes:

  • Manual workflow trigger via workflow_dispatch
  • Uses uv build and uv publish for modern Python package management
  • Configures OIDC trusted publishing with id-token: write permission
  • References pypi environment for deployment protection

Issues Found:

  • Uses non-existent actions/checkout@v6 (should be v4)
  • Missing build dependencies required by custom hatch hook (plotly, ruff, pre_commit, toml)
  • No explicit Python version setup, relying on runner default
  • Build will likely fail due to missing dependencies during .pyi file generation

Confidence Score: 2/5

  • This PR has critical issues that will prevent the workflow from executing successfully
  • The workflow uses an incorrect action version (v6 doesn't exist) and is missing required build dependencies specified in pyproject.toml. The custom hatch build hook requires plotly, ruff, pre_commit, and toml packages to generate .pyi files, but these aren't installed before building. This will cause the build step to fail.
  • .github/workflows/publish.yml requires corrections to action versions and dependency installation steps

Important Files Changed

Filename Overview
.github/workflows/publish.yml New PyPI publish workflow with incorrect checkout version and missing build dependencies

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Actions
    participant UV as UV Tool
    participant Hatch as Hatchling Build
    participant PyPI as PyPI Registry
    
    Dev->>GH: Trigger workflow_dispatch
    GH->>GH: Checkout code (v6)
    GH->>UV: Install uv tool
    GH->>UV: Run uv build
    UV->>Hatch: Invoke hatchling build backend
    Hatch->>Hatch: Execute custom build hook
    Note over Hatch: Requires: plotly, ruff,<br/>pre_commit, toml
    Hatch->>Hatch: Generate .pyi files
    Hatch-->>UV: Return build artifacts
    UV-->>GH: Build complete
    GH->>UV: Run uv publish
    UV->>PyPI: Publish using OIDC trusted publishing
    Note over UV,PyPI: Uses id-token permission
    PyPI-->>UV: Publish successful
    UV-->>GH: Publish complete
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@adhami3310 adhami3310 merged commit b1b450a into main Dec 20, 2025
48 checks passed
@adhami3310 adhami3310 deleted the publish-job branch December 20, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants