set ComputedVar cache default to False #5968
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default value of the
cacheparameter inComputedVarfromTruetoFalseto align with the documented behavior at https://reflex.dev/docs/vars/computed-vars#cached-vars.Background
According to the documentation:
@rx.varshould recompute on every state change (cache=False behavior)@rx.var(cache=True)should only recompute when dependencies change (cached behavior)However, the current implementation has
cache=Trueas the default in thecomputed_var()function andComputedVar.__init__(), which contradicts the documentation.Changes
Updated the default
cacheparameter toFalse.Related Issues
This change makes the code consistent with the documentation. As a result, PR in reflex-web (which updates the documentation to state that the default is
True) should be declined, as the code now correctly implementscache=Falseas the default behavior.Breaking Change
Existing computed vars that relied on the default caching behavior will no longer be cached automatically. Users who want caching enabled must now explicitly set
@rx.var(cache=True).Migration Guide
If you have existing code using computed vars that depends on caching: