Open
Conversation
CodSpeed Performance ReportMerging #5430 will not alter performanceComparing Summary
|
Contributor
There was a problem hiding this comment.
PR Summary
Simplified form data handling by removing ID-based refs, preventing duplicate submissions and fixing a production build ReferenceError in stateful components.
- Modified
reflex/components/el/elements/forms.pyto exclusively use FormData object for submissions, removing refs-based collection - Updated test suite in
tests/integration/test_form_submit.pyto remove ID-based form tests ('id-radix', 'id-html'), standardizing on name attributes - Fixed ReferenceError in production builds where
refswas undefined after hook extraction in stateful components (Issue #5418)
3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing both name and ids refs can lead to duplicate data, we should only pass form data by name.
Fix #5418 (when extracting hooks in stateful components, the form hook still refer
refsbut the import is removed, leading to the error)