Skip to content

Add LinkedIn links to founder avatars on about page#1804

Open
Alek99 wants to merge 2 commits intomainfrom
alek/about-linkedin-links
Open

Add LinkedIn links to founder avatars on about page#1804
Alek99 wants to merge 2 commits intomainfrom
alek/about-linkedin-links

Conversation

@Alek99
Copy link
Copy Markdown
Member

@Alek99 Alek99 commented Apr 1, 2026

Summary

  • Wrap Alek and Nikhil's avatar images on the /about page with links to their LinkedIn profiles
  • Links open in a new tab

Test plan

  • Visit /about page and verify avatars are clickable
  • Confirm links open correct LinkedIn profiles in new tabs

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 1, 2026

Greptile Summary

This PR wraps the founder avatar images on the /about page with rx.el.a anchor elements linking to Alek and Nikhil's LinkedIn profiles, opening in a new tab. The change is small, focused, and correctly uses rx.el.a (unstyled) rather than rx.link (prestyled) to avoid unwanted underline styling — consistent with the project's convention.

Key changes:

  • Avatar images for Alek and Nikhil are now wrapped in rx.el.a links pointing to their respective LinkedIn profiles
  • target="_blank" is set on both links so they open in a new tab
  • The pointer-events-none CSS class is correctly removed from both images (it was preventing clicks; now clicks should be allowed)
  • Both links are missing rel="noopener noreferrer", which is a minor best-practice omission for external target="_blank" links

Confidence Score: 5/5

  • Safe to merge — a simple, well-scoped UI change with only a minor best-practice omission.
  • The only finding is a P2 style suggestion (missing rel="noopener noreferrer"), which does not affect correctness or functionality. All other aspects of the change are correct and follow established project conventions.
  • No files require special attention.

Important Files Changed

Filename Overview
pcweb/pages/about/views/hero.py Wraps Alek and Nikhil avatar images in rx.el.a links pointing to their LinkedIn profiles; removes pointer-events-none class and adds target="_blank" for new-tab behaviour. Minor: rel="noopener noreferrer" is absent.

Sequence Diagram

sequenceDiagram
    actor User
    participant AboutPage as /about Page
    participant LinkedIn as LinkedIn Profile

    User->>AboutPage: Visits /about
    AboutPage->>User: Renders hero section with avatar images (now wrapped in links)
    User->>AboutPage: Clicks Alek's avatar
    AboutPage->>LinkedIn: Opens linkedin.com/in/aleksanderpetuskey/ (new tab)
    User->>AboutPage: Clicks Nikhil's avatar
    AboutPage->>LinkedIn: Opens linkedin.com/in/nrao95/ (new tab)
Loading

Reviews (1): Last reviewed commit: "Add LinkedIn links to founder avatars on..." | Re-trigger Greptile

Comment on lines +61 to +72
href="https://www.linkedin.com/in/aleksanderpetuskey/",
target="_blank",
),
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full pointer-events-none",
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/nrao95/",
target="_blank",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing rel="noopener noreferrer" on external links

Both target="_blank" links are missing rel="noopener noreferrer". While modern browsers (Chrome 88+, Firefox 79+) now automatically add noopener behavior for target="_blank" links, it's still a best practice to include it explicitly for older browsers and to signal intent clearly. noreferrer additionally prevents the HTTP Referer header from being sent to LinkedIn.

Suggested change
href="https://www.linkedin.com/in/aleksanderpetuskey/",
target="_blank",
),
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full pointer-events-none",
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/nrao95/",
target="_blank",
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/alek.avif",
alt="Alek",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/aleksanderpetuskey/",
target="_blank",
rel="noopener noreferrer",
),
rx.el.a(
rx.image(
src=f"{REFLEX_ASSETS_CDN}about/nikhil.avif",
alt="Nikhil",
custom_attrs={"fetchPriority": "high"},
class_name="size-8 rounded-full",
),
href="https://www.linkedin.com/in/nrao95/",
target="_blank",
rel="noopener noreferrer",
),

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant