Conversation
Greptile SummaryThis PR introduces LD+JSON structured data support for docs pages by reading an Key changes:
Confidence Score: 5/5Safe to merge; the only finding is a minor defensive-programming suggestion that does not block production functionality. All findings are P2 style/robustness suggestions. The core logic is correct: No files require special attention beyond the minor type-guard suggestion in Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Doc file .md with optional ldjson frontmatter] --> B{Doc type?}
B -->|flexdown local| C[get_component]
B -->|reflex-package docgen| D[get_component_docgen]
C --> C1[load_flexdown_doc]
C1 --> C2[read ldjson from metadata]
C2 --> C3{ldjson truthy?}
C3 -->|Yes| C4[jsonld_script ldjson]
C3 -->|No| C5[xd.render doc]
C4 --> C6[rx.fragment - script + rendered]
C5 --> C7[return toc + rendered]
C6 --> C7
D --> D1[try: load_flexdown_doc for metadata]
D1 -->|OSError or ValueError| D2[ldjson = None]
D1 -->|success| D3[read ldjson from metadata]
D3 --> D4{ldjson truthy?}
D4 -->|Yes| D5[jsonld_script ldjson]
D4 -->|No| D6[render_docgen_document]
D5 --> D7[rx.fragment - script + rendered]
D6 --> D8[return toc + rendered]
D7 --> D8
C7 --> E[make_docpage - docpage decorator]
D8 --> E
subgraph jsonld_script_fn[jsonld_script]
J1[data dict input] --> J2{context key present?}
J2 -->|No| J3[prepend context schema.org]
J2 -->|Yes| J4[use dict as-is]
J3 --> J5[rx.el.script with json.dumps]
J4 --> J5
end
Reviews (1): Last reviewed commit: "ENG-9266: Support ld+json for docs pages" | Re-trigger Greptile |
No description provided.