Skip to content

update google headers #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alek99 merged 2 commits into from
Jan 10, 2026
Merged

update google headers #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ac5124
update google headers
Jan 8, 2026
93f6eda
Merge branch 'main' into update-google-taglines
tgberkeley Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pcweb/pages/landing/landing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
from pcweb.templates.mainpage import mainpage


@mainpage(path="/", title="Reflex · Web apps in Pure Python", meta=meta_tags)
@mainpage(
path="/",
title="Reflex · The platform to build and scale enterprise apps",
meta=meta_tags,
)
def landing() -> rx.Component:
return rx.el.div(
hero(),
Expand Down
5 changes: 3 additions & 2 deletions pcweb/templates/mainpage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@
from pcweb.meta.meta import meta_tags
from pcweb.route import Route

DEFAULT_TITLE = "Web Apps in Pure Python"
DEFAULT_TITLE = "The platform to build and scale enterprise apps"
DEFAULT_DESCRIPTION = "Connect to all your company data and systems to build secure internal apps with AI. Deployed on prem with built-in governance and production-grade reliability, so technical and nontechnical teams can ship together."
Comment on lines +8 to +9
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these string literals are duplicated across mainpage.py and webpage.py - consider extracting them to a shared constants module to maintain consistency

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!



def mainpage(
path: str,
title: str = DEFAULT_TITLE,
description: str | None = None,
description: str | None = DEFAULT_DESCRIPTION,
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing default from None to DEFAULT_DESCRIPTION means ALL pages using @mainpage without explicit description will get this enterprise-focused description, which may not be appropriate for non-landing pages

image: str | None = None,
meta: list[dict[str, str]] = meta_tags,
props=None,
Expand Down
5 changes: 3 additions & 2 deletions pcweb/templates/webpage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@

from pcweb.route import Route

DEFAULT_TITLE = "Web Apps in Pure Python"
DEFAULT_TITLE = "The platform to build and scale enterprise apps"
DEFAULT_DESCRIPTION = "Connect to all your company data and systems to build secure internal apps with AI. Deployed on prem with built-in governance and production-grade reliability, so technical and nontechnical teams can ship together."
Comment on lines +8 to +9
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these string literals are duplicated across mainpage.py and webpage.py - consider extracting them to a shared constants module to maintain consistency

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!



def webpage(
path: str,
title: str = DEFAULT_TITLE,
description: str | None = None,
description: str | None = DEFAULT_DESCRIPTION,
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing default from None to DEFAULT_DESCRIPTION means ALL pages using @webpage without explicit description will get this enterprise-focused description, which may not be appropriate for pages like blog, FAQ, docs, etc

image: str | None = None,
meta: list[dict[str, str]] | None = None,
props=None,
Expand Down
Loading