Skip to content

Refactor meta.py: abstract common keywords and remove duplicate code #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alek99 merged 2 commits into from
Dec 8, 2025
Merged

Refactor meta.py: abstract common keywords and remove duplicate code #1708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef16bd
Refactor meta.py: abstract common keywords and remove duplicate code
Alek99 Dec 8, 2025
3a2b8d8
Remove keywords meta tag
Alek99 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
170 changes: 73 additions & 97 deletions pcweb/meta/meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,73 +2,64 @@

from pcweb.constants import REFLEX_DOMAIN, REFLEX_DOMAIN_URL, TWITTER_CREATOR

TITLE = "The unified platform to build and scale enterprise apps."
Copy link
Contributor

@greptile-apps greptile-apps bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This refactoring changes the og:title and twitter:title from "Reflex · Build with AI, Deploy with Python" to "The unified platform to build and scale enterprise apps." - this alters social media preview titles and wasn't mentioned in the PR description

Suggested change
TITLE = "The unified platform to build and scale enterprise apps."
TITLE = "Reflex · Build with AI, Deploy with Python"
Prompt To Fix With AI 
This is a comment left during a code review.
Path: pcweb/meta/meta.py
Line: 5:5

Comment:
**logic:** This refactoring changes the `og:title` and `twitter:title` from "Reflex · Build with AI, Deploy with Python" to "The unified platform to build and scale enterprise apps." - this alters social media preview titles and wasn't mentioned in the PR description

```suggestion
TITLE = "Reflex · Build with AI, Deploy with Python"
```

How can I resolve this? If you propose a fix, please make it concise.

ONE_LINE_DESCRIPTION = "Build with AI, iterate in Python, deploy to any cloud. The unified platform to build and scale enterprise apps."

meta_tags = [
# HTML Meta Tags
{"name": "application-name", "content": "Reflex"},
{
"name": "keywords",
"content": "reflex, python, web apps, framework, open source, frontend, backend, full stack",
},
{
"name": "description",
"content": ONE_LINE_DESCRIPTION,
},
# Facebook Meta Tags
{"property": "og:url", "content": REFLEX_DOMAIN_URL},
{"property": "og:type", "content": "website"},
{"property": "og:title", "content": "Reflex · Build with AI, Deploy with Python"},
{
"property": "og:description",
"content": ONE_LINE_DESCRIPTION,
},
{"property": "og:image", "content": "/previews/index_preview.webp"},
# Twitter Meta Tags
{"name": "twitter:card", "content": "summary_large_image"},
{"property": "twitter:domain", "content": REFLEX_DOMAIN},
{"property": "twitter:url", "content": REFLEX_DOMAIN_URL},
{"name": "twitter:title", "content": "Reflex · Build with AI, Deploy with Python"},
{
"name": "twitter:description",
"content": ONE_LINE_DESCRIPTION,
},
{"name": "twitter:image", "content": "/previews/index_preview.webp"},
{"name": "twitter:creator", "content": TWITTER_CREATOR},
]

hosting_meta_tags = [
# HTML Meta Tags
{"name": "application-name", "content": "Reflex"},
{
"name": "keywords",
"content": "reflex, python, web apps, framework, open source, frontend, backend, full stack",
},
{
"name": "description",
"content": ONE_LINE_DESCRIPTION,
},
# Facebook Meta Tags
{"property": "og:url", "content": REFLEX_DOMAIN_URL},
{"property": "og:type", "content": "website"},
{"property": "og:title", "content": "Reflex · Build with AI, Deploy with Python"},
{
"property": "og:description",
"content": ONE_LINE_DESCRIPTION,
},
{"property": "og:image", "content": "/previews/hosting_preview.webp"},
# Twitter Meta Tags
{"name": "twitter:card", "content": "summary_large_image"},
{"property": "twitter:domain", "content": REFLEX_DOMAIN},
{"property": "twitter:url", "content": REFLEX_DOMAIN_URL},
{"name": "twitter:title", "content": "Reflex · Build with AI, Deploy with Python"},
{
"name": "twitter:description",
"content": ONE_LINE_DESCRIPTION,
},
{"name": "twitter:image", "content": "/previews/hosting_preview.webp"},
{"name": "twitter:creator", "content": TWITTER_CREATOR},
]
# Common constants
APPLICATION_NAME = "Reflex"
TWITTER_CARD_TYPE = "summary_large_image"
OG_TYPE = "website"


def _build_meta_tags(
title: str,
description: str,
image: str,
url: str = REFLEX_DOMAIN_URL,
) -> list[dict[str, str]]:
"""Build a list of meta tags with the given parameters.

Args:
title: The page title.
description: The page description.
image: The image path for social media previews.
url: The page URL (defaults to REFLEX_DOMAIN_URL).

Returns:
A list of meta tag dictionaries.
"""
return [
# HTML Meta Tags
{"name": "application-name", "content": APPLICATION_NAME},
{"name": "description", "content": description},
# Facebook Meta Tags
{"property": "og:url", "content": url},
{"property": "og:type", "content": OG_TYPE},
{"property": "og:title", "content": title},
{"property": "og:description", "content": description},
{"property": "og:image", "content": image},
# Twitter Meta Tags
{"name": "twitter:card", "content": TWITTER_CARD_TYPE},
{"property": "twitter:domain", "content": REFLEX_DOMAIN},
{"property": "twitter:url", "content": url},
{"name": "twitter:title", "content": title},
{"name": "twitter:description", "content": description},
{"name": "twitter:image", "content": image},
{"name": "twitter:creator", "content": TWITTER_CREATOR},
]


meta_tags = _build_meta_tags(
title=TITLE,
description=ONE_LINE_DESCRIPTION,
image="/previews/index_preview.webp",
)

hosting_meta_tags = _build_meta_tags(
title=TITLE,
description=ONE_LINE_DESCRIPTION,
image="/previews/hosting_preview.webp",
)


def favicons_links() -> list[rx.Component]:
Expand All @@ -90,42 +81,27 @@ def favicons_links() -> list[rx.Component]:
def create_meta_tags(
title: str, description: str, image: str, url: str | None = None
) -> list[rx.Component]:
"""Create meta tags for a page.

Args:
title: The page title.
description: The page description.
image: The image path for social media previews.
url: The page URL (optional, defaults to REFLEX_DOMAIN_URL).

Returns:
A list of meta tag dictionaries.
"""
page_url = url if url else REFLEX_DOMAIN_URL

if image and not image.startswith(("http://", "https://")):
image_url = f"https://reflex.dev{'' if image.startswith('/') else '/'}{image}"
else:
image_url = image

return [
# HTML Meta Tags
{"name": "application-name", "content": "Reflex"},
{
"name": "keywords",
"content": "reflex, python, web apps, framework, open source, frontend, backend, full stack",
},
{
"name": "description",
"content": description,
},
# Facebook Meta Tags
{"property": "og:url", "content": page_url},
{"property": "og:type", "content": "website"},
{"property": "og:title", "content": title},
{
"property": "og:description",
"content": description,
},
{"property": "og:image", "content": image_url},
# Twitter Meta Tags
{"name": "twitter:card", "content": "summary_large_image"},
{"property": "twitter:domain", "content": REFLEX_DOMAIN},
{"property": "twitter:url", "content": page_url},
{"name": "twitter:title", "content": title},
{
"name": "twitter:description",
"content": description,
},
{"name": "twitter:image", "content": image_url},
{"name": "twitter:creator", "content": TWITTER_CREATOR},
]
return _build_meta_tags(
title=title,
description=description,
image=image_url,
url=page_url,
)