-
Notifications
You must be signed in to change notification settings - Fork 229
feat: Add Products dropdown and Solutions dropdown to navbar #1703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Alek99
commented
Dec 5, 2025
- Created Products dropdown containing AI Builder, Open Source, and Cloud
- Created Solutions dropdown with App Types (Internal Tools, Data & AI Apps, Customer Facing Apps) and Industries (Finance, Healthcare, Energy, Enterprise)
- Updated navbar menu trigger to support active states for dropdowns
- Reorganized navbar items: Products, Docs, Resources, Solutions, Pricing
- Fixed icon names to use valid icons from the icon library
- Created Products dropdown containing AI Builder, Open Source, and Cloud - Created Solutions dropdown with App Types (Internal Tools, Data & AI Apps, Customer Facing Apps) and Industries (Finance, Healthcare, Energy, Enterprise) - Updated navbar menu trigger to support active states for dropdowns - Reorganized navbar items: Products, Docs, Resources, Solutions, Pricing - Fixed icon names to use valid icons from the icon library
Greptile OverviewGreptile SummaryThis PR restructures the navbar to add two new dropdown menus - Products and Solutions. The Products dropdown consolidates AI Builder, Open Source, and Cloud offerings with conditional rendering based on the current route. The Solutions dropdown introduces organized sections for App Types (Internal Tools, Data & AI Apps, Customer Facing Apps) and Industries (Finance, Healthcare, Energy, Enterprise). Key changes:
Minor issue found:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Navbar
participant Router
participant ProductsDropdown
participant SolutionsDropdown
User->>Navbar: Hover over "Product" trigger
Navbar->>Router: Get current route path
Router-->>Navbar: Return path (e.g., "/docs/...")
Navbar->>Navbar: Calculate active state for Products
Note over Navbar: Checks if path contains:<br/>"ai-builder", "cloud", "hosting",<br/>or framework docs
Navbar->>ProductsDropdown: Display dropdown menu
ProductsDropdown->>Router: Check if on docs/ai-builder/cloud
Router-->>ProductsDropdown: Return path condition
alt On docs/ai-builder/cloud pages
ProductsDropdown->>User: Show internal doc links
else On other pages
ProductsDropdown->>User: Show external AI Builder + internal links
end
User->>Navbar: Hover over "Solutions" trigger
Navbar->>Router: Get current route path
Router-->>Navbar: Return path
Navbar->>Navbar: Calculate active state for Solutions
Note over Navbar: Checks if path contains "use-cases"
Navbar->>SolutionsDropdown: Display dropdown menu
SolutionsDropdown->>User: Show App Types and Industries columns
User->>SolutionsDropdown: Click "Finance" industry
SolutionsDropdown->>Router: Navigate to finance_use_case_page.path
Router->>User: Display Finance use case page
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| if active_str == "products": | ||
| is_docs = router_path.contains("docs") | ||
| is_open_source_page = router_path.contains("open-source") | ||
| not_cloud = ~(router_path.contains("cloud") | router_path.contains("hosting")) | ||
| not_ai_builder = ~router_path.contains("ai-builder") | ||
| is_framework = (is_docs & not_cloud & not_ai_builder) | is_open_source_page | ||
| active = router_path.contains("ai-builder") | router_path.contains("cloud") | router_path.contains("hosting") | is_framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: duplicated logic from link_item function lines 69-75 - extract this "products" active state calculation into a shared helper function
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/components/docpage/navbar/navbar.py
Line: 450:456
Comment:
**style:** duplicated logic from `link_item` function lines 69-75 - extract this "products" active state calculation into a shared helper function
How can I resolve this? If you propose a fix, please make it concise.409bacc to
9f18d34
Compare