-
Notifications
You must be signed in to change notification settings - Fork 229
Hide Pro #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide Pro #1688
Conversation
Greptile OverviewGreptile SummaryTemporarily hides the Pro tier from the pricing page by commenting out the Pro plan card and Pro column in comparison tables, adjusting layouts from 3-column to 2-column grid (Hobby + Enterprise only). Key Changes:
Critical Issues:
Required Actions Before Merge:
Confidence Score: 0/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant PricingPage
participant PlanCards
participant TiersTable
User->>PricingPage: Visit pricing page
PricingPage->>PlanCards: Render plan_cards()
PlanCards->>PlanCards: Show Hobby card (Free tier)
PlanCards->>PlanCards: Skip Pro card (commented out)
PlanCards->>PlanCards: Show Enterprise card (popular)
PlanCards-->>PricingPage: Display 2-column grid layout
PricingPage->>TiersTable: Render tiers_tables()
TiersTable->>TiersTable: Show sticky header (Hobby + Enterprise)
TiersTable->>TiersTable: Skip Pro column (commented out)
TiersTable->>TiersTable: Render feature tables (2 columns)
TiersTable-->>PricingPage: Display comparison tables
User->>PlanCards: Click "Start building for free"
PlanCards-->>User: Redirect to REFLEX_BUILD_URL
User->>PlanCards: Click "Contact sales"
PlanCards-->>User: Show demo form dialog
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (6)
-
pcweb/pages/pricing/plan_cards.py, line 13-18 (link)logic:
YEARLY_MONTHS_FREE,YEARLY_DISCOUNT_MULTIPLIER, andmonthly_yearly_toggle_csare defined but never used - remove themContext Used: Rule from
dashboard- Remove commented-out code before merging PRs. (source) -
pcweb/pages/pricing/plan_cards.py, line 26-45 (link)logic:
ProTierStateclass is defined but never used - remove itContext Used: Rule from
dashboard- Remove commented-out code before merging PRs. (source) -
pcweb/pages/pricing/plan_cards.py, line 160-173 (link)logic:
pro_tiers_select()function is defined but never used - remove itContext Used: Rule from
dashboard- Remove commented-out code before merging PRs. (source) -
pcweb/pages/pricing/plan_cards.py, line 284-304 (link)logic:
monthly_yearly_toggle()function is defined but never used - remove itContext Used: Rule from
dashboard- Remove commented-out code before merging PRs. (source) -
pcweb/pages/pricing/plan_cards.py, line 310 (link)logic: Remove commented-out code before merging
Context Used: Rule from
dashboard- Remove commented-out code before merging PRs. (source) -
pcweb/pages/pricing/table.py, line 131-150 (link)logic: Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
Context Used: Rule from
dashboard- Remove commented-out code before merging PRs. (source)
2 files reviewed, 15 comments
| from pcweb.components.hosting_banner import HostingBannerState | ||
| from pcweb.components.number_flow import number_flow | ||
| from pcweb.constants import PRO_TIERS_TABLE, REFLEX_BUILD_URL, REFLEX_CLOUD_URL | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: REFLEX_CLOUD_URL is imported but never used - remove it
| from pcweb.constants import PRO_TIERS_TABLE, REFLEX_BUILD_URL |
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/plan_cards.py
Line: 11:11
Comment:
**logic:** `REFLEX_CLOUD_URL` is imported but never used - remove it
```suggestion
from pcweb.constants import PRO_TIERS_TABLE, REFLEX_BUILD_URL
```
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.| # "Pro", | ||
| # number_flow( | ||
| # value=rx.cond( | ||
| # monthly_yearly_toggle_cs.value == "monthly", | ||
| # ProTierState.selected_tier["price"], | ||
| # round( | ||
| # ProTierState.selected_tier["price"] | ||
| # * YEARLY_DISCOUNT_MULTIPLIER, | ||
| # 1, | ||
| # ), | ||
| # ), | ||
| # trend="0", | ||
| # prefix="$", | ||
| # suffix=" /monthly", | ||
| # class_name="text-3xl text-secondary-12 font-semibold py-4", | ||
| # ), | ||
| # "Build, deploy and scale your apps.", | ||
| # [ | ||
| # Feature("TokenCircleIcon", "", pro_tiers_select()), | ||
| # Feature("SquareLock02Icon", "Private Projects"), | ||
| # Feature("CursorInWindowIcon", "Full-Fledged Browser IDE"), | ||
| # Feature("PlugSocketIcon", "Integrations"), | ||
| # Feature("GithubIcon", "Connect to Github"), | ||
| # Feature("Globe02Icon", "Custom Domains"), | ||
| # Feature("CpuIcon", "Up to 8 GB RAM / 4 vCPU per deployed app"), | ||
| # ], | ||
| # ui.button( | ||
| # "Start with Pro plan", | ||
| # variant="secondary", | ||
| # size="lg", | ||
| # class_name="w-full font-semibold", | ||
| # on_click=ProTierState.redirect_to_billing( | ||
| # monthly_yearly_toggle_cs.value == "yearly" | ||
| # ), | ||
| # ), | ||
| # ), | ||
| popular_card( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Remove commented-out code before merging
| # "Pro", | |
| # number_flow( | |
| # value=rx.cond( | |
| # monthly_yearly_toggle_cs.value == "monthly", | |
| # ProTierState.selected_tier["price"], | |
| # round( | |
| # ProTierState.selected_tier["price"] | |
| # * YEARLY_DISCOUNT_MULTIPLIER, | |
| # 1, | |
| # ), | |
| # ), | |
| # trend="0", | |
| # prefix="$", | |
| # suffix=" /monthly", | |
| # class_name="text-3xl text-secondary-12 font-semibold py-4", | |
| # ), | |
| # "Build, deploy and scale your apps.", | |
| # [ | |
| # Feature("TokenCircleIcon", "", pro_tiers_select()), | |
| # Feature("SquareLock02Icon", "Private Projects"), | |
| # Feature("CursorInWindowIcon", "Full-Fledged Browser IDE"), | |
| # Feature("PlugSocketIcon", "Integrations"), | |
| # Feature("GithubIcon", "Connect to Github"), | |
| # Feature("Globe02Icon", "Custom Domains"), | |
| # Feature("CpuIcon", "Up to 8 GB RAM / 4 vCPU per deployed app"), | |
| # ], | |
| # ui.button( | |
| # "Start with Pro plan", | |
| # variant="secondary", | |
| # size="lg", | |
| # class_name="w-full font-semibold", | |
| # on_click=ProTierState.redirect_to_billing( | |
| # monthly_yearly_toggle_cs.value == "yearly" | |
| # ), | |
| # ), | |
| # ), | |
| popular_card( |
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/plan_cards.py
Line: 202:238
Comment:
**logic:** Remove commented-out code before merging
```suggestion
```
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.|
|
||
| from pcweb.components.hosting_banner import HostingBannerState | ||
| from pcweb.constants import REFLEX_BUILD_URL, REFLEX_CLOUD_URL | ||
| from pcweb.constants import REFLEX_BUILD_URL # , REFLEX_CLOUD_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: REFLEX_CLOUD_URL is commented out but never used - remove the commented import
| from pcweb.constants import REFLEX_BUILD_URL # , REFLEX_CLOUD_URL | |
| from pcweb.constants import REFLEX_BUILD_URL |
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/table.py
Line: 6:6
Comment:
**logic:** `REFLEX_CLOUD_URL` is commented out but never used - remove the commented import
```suggestion
from pcweb.constants import REFLEX_BUILD_URL
```
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.| CLOUD_HOSTING_FEATURES = [ | ||
| ("Max # Apps", "1", "5", "10"), | ||
| ("Max Machine Size", "1cpu, 1gb", "2cpu, 4gb shared", "Beyond 2cpu, 4gb"), | ||
| ("Dedicated Machines", False, False, True), | ||
| ("Custom Domains", "0", "5", "Unlimited"), | ||
| ("App Metrics", True, True, True), | ||
| ("Log Retention", "1 hour", "7 day", "90-Day Log History"), | ||
| ("Multiple Regions", False, True, True), | ||
| ('"Built with Reflex" Attribution', True, False, False), | ||
| ("One-click rollbacks", True, True, True), | ||
| ( | ||
| "Max # Apps", | ||
| "1", | ||
| # "5", | ||
| "10", | ||
| ), | ||
| ( | ||
| "Max Machine Size", | ||
| "1cpu, 1gb", | ||
| # "2cpu, 4gb shared", | ||
| "Beyond 2cpu, 4gb", | ||
| ), | ||
| ( | ||
| "Dedicated Machines", | ||
| False, | ||
| # False, | ||
| True, | ||
| ), | ||
| ( | ||
| "Custom Domains", | ||
| "0", | ||
| # "5", | ||
| "Unlimited", | ||
| ), | ||
| ( | ||
| "App Metrics", | ||
| True, | ||
| # True, | ||
| True, | ||
| ), | ||
| ( | ||
| "Log Retention", | ||
| "1 hour", | ||
| # "7 day", | ||
| "90-Day Log History", | ||
| ), | ||
| ( | ||
| "Multiple Regions", | ||
| False, | ||
| # True, | ||
| True, | ||
| ), | ||
| ( | ||
| '"Built with Reflex" Attribution', | ||
| True, | ||
| # False, | ||
| False, | ||
| ), | ||
| ( | ||
| "One-click rollbacks", | ||
| True, | ||
| # True, | ||
| True, | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/table.py
Line: 8:63
Comment:
**logic:** Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.| SECURITY_FEATURES = [ | ||
| ("SSO/SAML", False, True, True), | ||
| ("Role-based access control", False, False, True), | ||
| ("On Premise Deployments", False, False, True), | ||
| ("Audit Logs", False, False, True), | ||
| ("HTTP/SSL", True, True, True), | ||
| ("Web App Firewall", True, True, True), | ||
| ("SOC 2 compliance", False, False, "On prem, custom"), | ||
| ("HIPAA BAA", False, False, "On prem, custom"), | ||
| ( | ||
| "SSO/SAML", | ||
| False, | ||
| # True, | ||
| True, | ||
| ), | ||
| ( | ||
| "Role-based access control", | ||
| False, | ||
| # False, | ||
| True, | ||
| ), | ||
| ( | ||
| "On Premise Deployments", | ||
| False, | ||
| # False, | ||
| True, | ||
| ), | ||
| ( | ||
| "Audit Logs", | ||
| False, | ||
| # False, | ||
| True, | ||
| ), | ||
| ( | ||
| "HTTP/SSL", | ||
| True, | ||
| # True, | ||
| True, | ||
| ), | ||
| ( | ||
| "Web App Firewall", | ||
| True, | ||
| # True, | ||
| True, | ||
| ), | ||
| ( | ||
| "SOC 2 compliance", | ||
| False, | ||
| # False, | ||
| "On prem, custom", | ||
| ), | ||
| ( | ||
| "HIPAA BAA", | ||
| False, | ||
| # False, | ||
| "On prem, custom", | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/table.py
Line: 65:114
Comment:
**logic:** Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.| SUPPORT_FEATURES = [ | ||
| ( | ||
| "Customer Success", | ||
| "Discord/Github Community", | ||
| "Discord/Github Community", | ||
| # "Discord/Github Community", | ||
| "Dedicated Support Channel", | ||
| ), | ||
| ( | ||
| "Onboarding", | ||
| "Documentation", | ||
| "Documentation", | ||
| # "Documentation", | ||
| "Get a forward deployed engineer to help you get started", | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/table.py
Line: 116:129
Comment:
**logic:** Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.| REFLEX_BUILD_FUNCTIONALITY = [ | ||
| ( | ||
| "Privacy", | ||
| "Public Projects", | ||
| "Private Projects", | ||
| # "Private Projects", | ||
| "Private Projects /Group based controls", | ||
| ), | ||
| ( | ||
| "Design", | ||
| "Custom Designs/Theming", | ||
| # "Custom Designs/Theming", | ||
| "Custom Designs/Theming", | ||
| "Custom Designs/Theming", | ||
| ), | ||
| ("Data", False, False, "Opt out of data training"), | ||
| ("Collaborators", "Single", "Single", "Multiple Collaborators/Editors"), | ||
| ("Integration", "Basic 5", "Pro 100+", "Enterprise Integrations"), | ||
| ("Download App Code", False, True, True), | ||
| ( | ||
| "Data", | ||
| False, | ||
| # False, | ||
| "Opt out of data training", | ||
| ), | ||
| ( | ||
| "Collaborators", | ||
| "Single", | ||
| # "Single", | ||
| "Multiple Collaborators/Editors", | ||
| ), | ||
| ( | ||
| "Integration", | ||
| "Basic 5", | ||
| # "Pro 100+", | ||
| "Enterprise Integrations", | ||
| ), | ||
| ( | ||
| "Download App Code", | ||
| False, | ||
| # True, | ||
| True, | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/table.py
Line: 152:189
Comment:
**logic:** Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.| REFLEX_BUILD_DEPLOYMENT = [ | ||
| ( | ||
| "Github", | ||
| "Public Repo Sync", | ||
| "Private Repo Sync", | ||
| # "Private Repo Sync", | ||
| "Enterprise Repo Sync Github, Gitlab, and Bitbucket.", | ||
| ), | ||
| ( | ||
| "One Click Deploy", | ||
| "Reflex Cloud", | ||
| "Reflex Cloud", | ||
| # "Reflex Cloud", | ||
| "Databricks, AWS, Azure, GCP, Other", | ||
| ), | ||
| ("SSH access", False, True, True), | ||
| ( | ||
| "SSH access", | ||
| False, | ||
| # True, | ||
| True, | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/table.py
Line: 191:210
Comment:
**logic:** Remove commented-out middle column values (Pro tier) from feature tuples
The tuples should only contain 2 values (Hobby and Enterprise), not 3 with the middle one commented out
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.| # header_item( | ||
| # "Pro", | ||
| # ui.link( | ||
| # render_=ui.button( | ||
| # "Upgrade now", | ||
| # variant="secondary", | ||
| # class_name="font-semibold w-full", | ||
| # ), | ||
| # to=f"{REFLEX_CLOUD_URL.rstrip('/')}/?redirect_url={REFLEX_CLOUD_URL.rstrip('/')}/billing/", | ||
| # target="_blank", | ||
| # ), | ||
| # ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Remove commented-out Pro tier header
| # header_item( | |
| # "Pro", | |
| # ui.link( | |
| # render_=ui.button( | |
| # "Upgrade now", | |
| # variant="secondary", | |
| # class_name="font-semibold w-full", | |
| # ), | |
| # to=f"{REFLEX_CLOUD_URL.rstrip('/')}/?redirect_url={REFLEX_CLOUD_URL.rstrip('/')}/billing/", | |
| # target="_blank", | |
| # ), | |
| # ), |
Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/pricing/table.py
Line: 338:349
Comment:
**logic:** Remove commented-out Pro tier header
```suggestion
```
**Context Used:** Rule from `dashboard` - Remove commented-out code before merging PRs. ([source](https://app.greptile.com/review/custom-context?memory=d49e2a0e-27a4-4cd6-b764-58c8a6fc4032))
How can I resolve this? If you propose a fix, please make it concise.
No description provided.