fix: add BACKEND_TIMEOUT error code with proper error handling#17
Merged
fix: add BACKEND_TIMEOUT error code with proper error handling#17
Conversation
- Add BACKEND_TIMEOUT error code constant (-32011) to error_codes module - Add explicit BackendTimeout match arm in to_error_payload() - Use inline format args for consistency - Add test coverage for BackendTimeout error code and payload message
Owner
Author
Review: ✅ LGTMClean implementation:
Verified:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BACKEND_TIMEOUTerror code constant (-32011) to theerror_codesmoduleBackendTimeoutmatch arm into_error_payload()instead of falling through tointernal_error()BackendTimeouterror code and payload message contentChanges
Previously,
BackendTimeouterrors fell through tointernal_error()into_error_payload(), returning a generic-32603code. Now it returns a specific-32011timeout error code with a descriptive message containing the backend name.This improves client-side error handling by allowing callers to distinguish timeout errors from other internal errors.
Testing
BackendTimeoutintest_error_payload_codetest_backend_timeout_payload_contains_nametest to verify message content