-
Notifications
You must be signed in to change notification settings - Fork 2
Add support for non-blocking bucket/entry deletions with status field #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ield Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
atimin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove file _codeql_detected_source_root. Pipelines are broken.
Suggestions:
- run cpplint before push the code
- test for reduct/store:main (new features) and reduct/store:stable (last stable version)
Update AGENTS.md.
|
@copilot retry |
Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
|
@copilot retry |
|
@copilot tests are broken. Check 404 or 409. For AGENTS.md: run tests for docker/store:main (dev version) and docker:store:latest( stable version) before pushing changes. |
Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
Updated AGENTS.md with version-specific testing guidelines in commit 04abc7e. The status field implementation is backward-compatible - The tests check for |
AGENTS.md
Outdated
| - PRs: describe intent and behavior changes, link issues, call out API impacts, include test commands/output, and note any server or env requirements. | ||
| - Ensure builds/tests pass before review; include screenshots only when modifying docs or examples. | ||
|
|
||
| ## Non-blocking Deletions (v1.18+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes in AGENTS.md.
Instead, add a prompt to AGENTS.md. Don't update the README or create examples for new features unless it has been requested in an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted feature documentation from AGENTS.md and added documentation guidelines in commit b4eb44b. The guidelines now instruct not to update README.md or create examples unless explicitly requested in the issue description.
|
@copilot the tests failed. Build and run tests before pushing changes. |
Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
Fixed test failure in commit c0a62bb. The test was expecting a 404 error when trying to remove an already-deleted entry, but with non-blocking deletions in v1.18, it returns 409 while the entry is being deleted. Updated the test to accept both 404 and 409 as valid responses. Tested against both reductstore:main (v1.18.0) and reductstore:latest (v1.17.8) - all tests pass successfully. |
Co-authored-by: atimin <67068+atimin@users.noreply.github.com>
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.