Conversation
rockwotj
approved these changes
Jan 22, 2026
| PolicyFile string | ||
| } | ||
|
|
||
| const authzConfigKey = "rp_gateway_authz_config" |
Contributor
There was a problem hiding this comment.
can we use a custom type here so it's impossible to get conflicts?
| ) | ||
|
|
||
| // Gateway HTTP authorization permission | ||
| const gatewayPermission authz.PermissionName = "dataplane_gateway" |
Contributor
Contributor
There was a problem hiding this comment.
dataplane_pipeline_gateway_invoke is the consensus in slack: https://redpandadata.slack.com/archives/C0A9JUKLPFS/p1769621564945579?thread_ts=1769527584.096319&cid=C0A9JUKLPFS
There was a problem hiding this comment.
plus one to call it dataplane_pipeline_gateway_invoke
Contributor
Author
|
Rebased, changed permission names, changed auth key type. |
rockwotj
approved these changes
Jan 29, 2026
|
|
||
| bindings: | ||
| - role: test.admin | ||
| principal: test@example.com |
Contributor
There was a problem hiding this comment.
these are User: prefixed now
Contributor
Author
There was a problem hiding this comment.
Thanks, I also noted the plural forms already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.