-
Notifications
You must be signed in to change notification settings - Fork 75
feat(migrate): [1/7] Core planner, validator, sync executor, and basic CLI #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bb4fc9c
feat(migrate): [1/7] add migration foundation with models, planner, v…
nkanu17 3dd8bc4
fix: foundation layer bug fixes and improvements (#560)
nkanu17 a607786
fix: add missing NOINDEX search assertion in integration test
nkanu17 2cff9bc
fix(validation): fix double-colon bug in prefix key transform + forma…
nkanu17 3314ebf
fix: address review round 3 for migrate-core (#560)
nkanu17 1f2d4fc
fix: address review round 4 for migrate-core (#560)
nkanu17 fdb6941
fix: address review round 5 for migrate-core (#560)
nkanu17 3755b05
feat(migrate): add sync MigrationExecutor to core PR (#560)
nkanu17 8689681
feat: add basic migrate CLI (plan, apply, validate, list, helper, est…
nkanu17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
exit(0)in CLI migrate command handlerLow Severity
The
migrate()method inRedisVlCLIdoes not callexit(0)afterMigrate(), unlikeindex(),version(), andstats()which all explicitly callexit(0). This is inconsistent and means the process relies on natural termination rather than an explicit exit code, which could matter if the CLI is called from scripts checking exit codes.