Conversation
Implements redis+sentinel:// URL scheme for high availability Redis deployments with automatic failover via Sentinel. URL format: redis+sentinel://[username:password@]host1:port1,host2:port2/service_name[/database] Features: - URL parsing with SentinelConfig.fromUrl() - Support for multiple comma-separated Sentinel hosts - IPv6 address handling in bracket notation - Authentication (username/password) - Database selection - Default values (port 26379, service "mymaster") - Integration with RedisConnectionManager via JedisSentinelPool Implementation details: - SentinelConfig: Parse and store Sentinel connection parameters - RedisConnectionManager: Detect redis+sentinel:// URLs and create JedisSentinelPool instead of standard JedisPool - Pool<Jedis> interface allows transparent handling of both pool types - Tests match Python implementation from PR #385 Python reference: redisvl/redis/connection.py - _parse_sentinel_url() Java files: - core/src/main/java/com/redis/vl/redis/SentinelConfig.java - core/src/main/java/com/redis/vl/redis/RedisConnectionManager.java:55-58 - core/src/test/java/com/redis/vl/redis/SentinelUrlParsingTest.java
bsbodden
force-pushed
the
bsb/sentinel_url_support
branch
from
9169c08 to
474feba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.