[8.6] Hotkeys - new command #3164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobymicroby
approved these changes
Jan 22, 2026
PavelPashov
approved these changes
Jan 22, 2026
| const reply = await client.hotkeysGet(); | ||
| assert.notEqual(reply, null); | ||
|
|
||
| if (reply !== null) { |
Contributor
There was a problem hiding this comment.
This if seems redundant given the assert above it
| import { parseArgs } from './generic-transformers'; | ||
|
|
||
| describe('HOTKEYS GET', () => { | ||
| testUtils.isVersionGreaterThanHook([8, 4]); |
Contributor
There was a problem hiding this comment.
This seems redundant if we're enforcing it in the minimumDockerVersion as well
| import { parseArgs } from './generic-transformers'; | ||
|
|
||
| describe('HOTKEYS RESET', () => { | ||
| testUtils.isVersionGreaterThanHook([8, 4]); |
Contributor
There was a problem hiding this comment.
This seems redundant if we're enforcing it in the minimumDockerVersion as well
| import { parseArgs } from './generic-transformers'; | ||
|
|
||
| describe('HOTKEYS STOP', () => { | ||
| testUtils.isVersionGreaterThanHook([8, 4]); |
Contributor
There was a problem hiding this comment.
This seems redundant if we're enforcing it in the minimumDockerVersion as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: tests will fail for XINFO_STREAM command and that is expected and unrelated to this PR
Starts/stops tracking of hotkeys in a redis-server instance and reports top K such keys. Hotkeys are measured by two metrics - cpu execution time and total bytes read/written from the network. Reporting returns meaningful results only during or after stopping tracking.
https://docs.google.com/document/d/14BKzU7u0b-B54b18AbW3WZEZWvIDwGzMPjHFg-Tksl0
Checklist
npm testpass with this change (including linting)?