Skip to content

Conversation

@nkaradzhov
Copy link
Collaborator

Description

NOTE: tests will fail for XINFO_STREAM command and that is expected and unrelated to this PR

Configures the idempotency parameters for a stream's IDMP map. Sets how long Redis remembers each iid and the maximum number of iids to track. This command clears the existing IDMP map (Redis forgets all previously stored iids), but only if the configuration value actually changes.

https://docs.google.com/document/d/1Bf9ElvtVmhTj9Q6AHj8Lf9-1dsK_I9FEh5v5vi56TBU

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

matrix:
node-version: ["18", "20", "22"]
redis-version: ["rs-7.4.0-v1", "8.0.2", "8.2", "8.4.0"]
redis-version: ["rs-7.4.0-v1", "8.0.2", "8.2", "custom-21183968220-debian-amd64"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace 8.0.2 instead of 8.4.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants