[8.6] Xadd changes #3161
Open
[8.6] Xadd changes #3161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelPashov
approved these changes
Jan 22, 2026
| matrix: | ||
| node-version: ["18", "20", "22"] | ||
| redis-version: ["rs-7.4.0-v1", "8.0.2", "8.2", "8.4.0"] | ||
| redis-version: ["rs-7.4.0-v1", "8.0.2", "8.2", "custom-21183968220-debian-amd64"] |
Contributor
There was a problem hiding this comment.
Should we replace 8.0.2 instead of 8.4.0?
| export interface XAddOptions { | ||
| /** added in 8.2 */ | ||
| policy?: StreamDeletionPolicy; | ||
| /** added in 8.2 */ |
| IDMPAUTO?: { | ||
| pid: RedisArgument; | ||
| }; | ||
| /** added in 8.2 */ |
PavelPashov
reviewed
Jan 22, 2026
| * | ||
| * | ||
| * @property policy - Reference tracking policy for the entry (KEEPREF, DELREF, or ACKED) - added in 8.2 | ||
| * @property IDMPAUTO - Automatically calculate an idempotent ID based on entry content to prevent duplicate entries - added in 8.2 |
PavelPashov
reviewed
Jan 22, 2026
| * @property policy - Reference tracking policy for the entry (KEEPREF, DELREF, or ACKED) - added in 8.2 | ||
| * @property IDMPAUTO - Automatically calculate an idempotent ID based on entry content to prevent duplicate entries - added in 8.2 | ||
| * @property IDMPAUTO.pid - Producer ID, must be unique per producer and consistent across restarts | ||
| * @property IDMP - Use a specific idempotent ID to prevent duplicate entries - added in 8.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: tests will fail for XINFO_STREAM command and that is expected and unrelated to this PR
https://docs.google.com/document/d/1RkGvTn_PhnU-LNrxJHTu08E4h5C3ZSIut6zS_cIl9dM
Checklist
npm testpass with this change (including linting)?