Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
mich-elle-luna
left a comment
mich-elle-luna
left a comment
There was a problem hiding this comment.
couple of questions otherwise looks good, thanks!
|
Thank you for the review, @mich-elle-luna! |
| * `tot-net-out`: total network output bytes sent to this client. | ||
| * `tot-cmds`: total count of commands this client executed. | ||
| * `read-events`: number of `readQueryFromClient()` calls for this client. Added in Redis 8.8 | ||
| * `avg-pipeline-len-sum`: cumulative sum of commands parsed per batch. Added in Redis 8.8 |
There was a problem hiding this comment.
Code says sum of pipeline lengths (for computing average)
https://github.com/redis/redis/blob/2ba0194fbe5820cab8602bfa633a7d27e97cabdd/src/server.h#L1622
Are you sure this is the same?
There was a problem hiding this comment.
I took this definition from your 8.8-M01 release notes.
| * `tot-cmds`: total count of commands this client executed. | ||
| * `read-events`: number of `readQueryFromClient()` calls for this client. Added in Redis 8.8 | ||
| * `avg-pipeline-len-sum`: cumulative sum of commands parsed per batch. Added in Redis 8.8 | ||
| * `avg-pipeline-len-cnt`: number of parse batches. Added in Redis 8.8 |
There was a problem hiding this comment.
Code says Count of pipeline length samples
https://github.com/redis/redis/blob/2ba0194fbe5820cab8602bfa633a7d27e97cabdd/src/server.h#L1623
Please check with R&D, I'm not sure what is correct.
There was a problem hiding this comment.
I took this definition from your 8.8-M01 release notes.
3 participants
Redis 8.8 feature
Note
Cursor Bugbot is generating a summary for commit db4b77b. Configure here.