Dev: enable prettier rules #5352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cache node_modules, redisinsight/node_modules, and redisinsight/api/node_modules - Skip yarn install when cache is restored - Use restore-keys for cross-branch cache fallback
- Add skip-system-deps input to install-all-build-libs action - Skip libsecret and rpm installation for lint job - These packages are only needed for Electron builds, not for linting
- Skip libsecret/rpm installation for lint, frontend, and backend tests - Remove unused inputs: skip-electron-deps, skip-backend-deps, skip-postinstall - Remove stale TODO comment
- Add lint.yml reusable workflow that runs yarn lint - Update tests.yml to call lint workflow first - All test jobs now depend on lint passing
Add inline eslint-disable comments for imports from api/dist which doesn't exist in CI (clean checkout without build artifacts).
Lint is now run as a blocking step before tests start, making this Slack-reporting-only step redundant.
- Remove redundant 'prettier' from extends arrays (already included by plugin:prettier/recommended) - Remove redundant 'prettier' from plugins arrays (auto-registered by plugin:prettier/recommended) - Remove deprecated createDefaultProgram option from parserOptions
pawelangelow
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pd-redis and
valkirilov
as code owners
Contributor
Code Coverage - Integration Tests
|
Contributor
Code Coverage - Frontend unit tests
Test suite run success5487 tests passing in 704 suites. Report generated by 🧪jest coverage report action from 755fc10 |
Contributor
Code Coverage - Backend unit tests
Test suite run success3009 tests passing in 287 suites. Report generated by 🧪jest coverage report action from 755fc10 |
valkirilov
approved these changes
Dec 19, 2025
pawelangelow
force-pushed
the
feature/run-eslint-in-ci
branch
from
e92effd to
030f55b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prettier consistently handles the formatting, so let's enable it for the whole codebase. IMO it's easier to check it commit by commit:
And these are what the automatic fixes did:
Testing
yarn lintandyarn lint --fixNote
Enable Prettier via ESLint and apply automated formatting across backend, frontend, and tests with minor lint rule/toplevel config tweaks; no functional changes.
plugin:prettier/recommended, remove redundantprettierplugin entries, refine rule overrides for API/UI/tests, and clean parser options; unify import/order rules.Written by Cursor Bugbot for commit 755fc10. This will update automatically on new commits. Configure here.