-
Notifications
You must be signed in to change notification settings - Fork 53
Test against Redis 8.6-pre #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
2c6eda5 to
7442202
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@sera ignore 41b2cc52aa reason:accepted |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the Redis version mapping mechanism from hardcoded bash logic to environment files. The change simplifies version management by creating individual .env files for each Redis version (6.2, 7.2, 7.4, 8.0, 8.2, 8.4, 8.6) that specify the appropriate Docker image and configuration.
Changes:
- Created seven environment files (
.env.v6.2through.env.v8.6) containing version-specific Docker image mappings and Redis arguments - Simplified the GitHub Actions workflow by removing the
redis_versionjob and updating the matrix to use semantic versioning (e.g.,8.4instead of8.4.0) - Refactored the
run-testsaction to source environment variables from version-specific files instead of using hardcoded bash mappings
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/dockers/.env.v8.6 | Adds environment configuration for Redis 8.6 with custom Docker image |
| tests/dockers/.env.v8.4 | Adds environment configuration for Redis 8.4 |
| tests/dockers/.env.v8.2 | Adds environment configuration for Redis 8.2 |
| tests/dockers/.env.v8.0 | Adds environment configuration for Redis 8.0 |
| tests/dockers/.env.v7.4 | Adds environment configuration for Redis 7.4 with Redis Stack image |
| tests/dockers/.env.v7.2 | Adds environment configuration for Redis 7.2 with Redis Stack image |
| tests/dockers/.env.v6.2 | Adds environment configuration for Redis 6.2 with Redis Stack image and extra arguments |
| .github/workflows/integration.yml | Removes redis_version job and updates matrix to use MAJOR.MINOR version format |
| .github/actions/run-tests/action.yml | Replaces hardcoded version mapping with env file sourcing logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6390ec4 to
1170340
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🛡️ Jit Security Scan Results🚨 Summary• No security vulnerabilities detected in this PR 🚫 Ignored Findings (1)HIGH (1)
|
Replaces hardcoded version mapping with more flexible .env file mapping.