Skip to content

Conversation

@uglide
Copy link
Contributor

@uglide uglide commented Jan 21, 2026

Replaces hardcoded version mapping with more flexible .env file mapping.

@jit-ci
Copy link

jit-ci bot commented Jan 21, 2026

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@uglide uglide force-pushed the im/use-env-files-for-redis-version-mapping branch from 2c6eda5 to 7442202 Compare January 21, 2026 10:14
@jit-ci

This comment has been minimized.

@jit-ci

This comment has been minimized.

@jit-ci

This comment has been minimized.

@uglide
Copy link
Contributor Author

uglide commented Jan 21, 2026

@sera ignore 41b2cc52aa reason:accepted

@jit-ci

This comment has been minimized.

@jit-ci

This comment has been minimized.

@jit-ci

This comment has been minimized.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Redis version mapping mechanism from hardcoded bash logic to environment files. The change simplifies version management by creating individual .env files for each Redis version (6.2, 7.2, 7.4, 8.0, 8.2, 8.4, 8.6) that specify the appropriate Docker image and configuration.

Changes:

  • Created seven environment files (.env.v6.2 through .env.v8.6) containing version-specific Docker image mappings and Redis arguments
  • Simplified the GitHub Actions workflow by removing the redis_version job and updating the matrix to use semantic versioning (e.g., 8.4 instead of 8.4.0)
  • Refactored the run-tests action to source environment variables from version-specific files instead of using hardcoded bash mappings

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/dockers/.env.v8.6 Adds environment configuration for Redis 8.6 with custom Docker image
tests/dockers/.env.v8.4 Adds environment configuration for Redis 8.4
tests/dockers/.env.v8.2 Adds environment configuration for Redis 8.2
tests/dockers/.env.v8.0 Adds environment configuration for Redis 8.0
tests/dockers/.env.v7.4 Adds environment configuration for Redis 7.4 with Redis Stack image
tests/dockers/.env.v7.2 Adds environment configuration for Redis 7.2 with Redis Stack image
tests/dockers/.env.v6.2 Adds environment configuration for Redis 6.2 with Redis Stack image and extra arguments
.github/workflows/integration.yml Removes redis_version job and updates matrix to use MAJOR.MINOR version format
.github/actions/run-tests/action.yml Replaces hardcoded version mapping with env file sourcing logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@uglide uglide changed the title Use env files for redis version mapping Test against Redis 8.6-pre Jan 21, 2026
@jit-ci

This comment has been minimized.

@jit-ci

This comment has been minimized.

@jit-ci

This comment has been minimized.

@uglide uglide force-pushed the im/use-env-files-for-redis-version-mapping branch from 6390ec4 to 1170340 Compare January 21, 2026 10:55
@jit-ci

This comment has been minimized.

@jit-ci

This comment has been minimized.

@jit-ci
Copy link

jit-ci bot commented Jan 21, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

🚨 Summary

• No security vulnerabilities detected in this PR

🚫 Ignored Findings (1)

HIGH (1)

▶️ Advanced Options

Help section with supported ignore actions and syntax.

Need to ignore a finding? Use commands like:

@sera ignore <finding_id> reason:accepted (reason is optional)

@sera ignore all reason:other - this is a test PR (reason is optional)

@sera ignore type:run-shell-injection


Security scan by Jit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants