fix: handle rate limits (429) and processing-completed state in task polling #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…polling - Add RateLimited error variant to CloudError for 429 responses - Add is_retryable() method to CloudError to identify transient errors - Add processing-completed as a terminal state (used by cost report API) - Implement retry with exponential backoff for 429/503 errors in task polling - Retry up to 5 times with delays from 1s to 30s before failing This fixes an issue where long-running --wait operations would fail with 'API error (429): You have exhausted your API Request Quota' due to aggressive polling without backoff. Closes #585 (partial)
… with global -o flag The field name 'output' conflicted with the global OutputFormat flag, causing a panic at runtime. Renamed to 'file' (--file/-f).
Updates from 0.7 to 0.8.3 which includes: - New text/NLP toolkit functions - Discovery module improvements - from_entries alias for from_items - Documentation improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes task polling failures when hitting API rate limits during
--waitoperations.Problem
When waiting for async tasks (like cost report generation), the CLI polls the
/tasks/{id}endpoint. With aggressive polling, users can hit the API rate limit (429), causing the operation to fail even though the task completed successfully:Additionally, the cost report API returns
processing-completedas a terminal state, which was not recognized.Changes
redis-cloudcrateRateLimitederror variant for 429 responses (was falling through to genericApiError)is_retryable()method toCloudError- returns true for 429, 503, and connection errorsredisctlcrateprocessing-completedas a terminal state (alongsidecompleted,succeeded, etc.)is_retryable()errorsTesting
is_retryable()methodprocessing-completedterminal state recognitionRelated
Partially addresses #585 (cost report CLI improvements)