Add Pre Commit Hooks and Editor Config#78
Draft
kdvalin wants to merge 3 commits into
Draft
Conversation
In general: - Use tab indents - No trailing whitespace - Unix style line endings - Add a newline at end of the file YAML is an execption, use 2 spaces for indentation. Avoid using tabs due to [the spec](https://yaml.org/spec/1.2.2/#61-indentation-spaces)
Contributor
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an .editorconfig to help enforce code standards.
Adds pre-commit framework to lint committed files. This works in addition to any pre-installed hooks (like Red Hat's leak checker)
Before/After Comparison
Before
Code style was not enforced, required manual review to catch problems.
After
Code style is automatically set by .editorconfig, more advanced linting issues are caught by the
shfmtpre-commit hook.Clerical Stuff
Closes TBD
Relates to JIRA: RPOPC-TBD