Add package management #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to RPOPC-687 |
kdvalin
added
the
group_review_lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the coremark_pro-wrapper with the new package management system being implemented across the Zathras test wrappers. It includes a JSON file which specifies the required packages to install on Amazon Linux, RHEL, SUSE, and Ubuntu, as well as an update to the main test execution script that invokes the JSON file when setting up to execute the benchmark.
Before/After Comparison
Before: Wrapper packages are installed by Zathras; running the wrapper standalone will fail without the packages pre-installed.
After: The wrapper can be run standalone, as packages are installed based on contents of the JSON file.
Clerical Stuff
This closes #47
Relates to JIRA: RPOPC-687