Transition from pbench to performance co pilot (pcp) #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --use_pcp option to enable PCP monitoring - Integrate PCP setup, logging, and cleanup into test execution - Add PCP iteration tracking and result collection - PCP functionality works alongside existing pbench support
- Remove all --pbench* command line options from README - Remove pbench execution branch from coremark_pro_run script - Remove pbench installation note from documentation - Simplify execution flow to use direct test execution only
|
This relates to RPOPC-632 |
malucius-rh
requested changes
Sep 30, 2025
coremark_pro/coremark_pro_run
Outdated
| kill $PMLOGGER_PID 2>/dev/null | ||
| wait $PMLOGGER_PID 2>/dev/null | ||
|
|
||
| stop_pcp_subset |
There was a problem hiding this comment.
Should this be shutdown_pcp, since this appears to be in the "wrapping things up" stage?
dvalinrh
requested changes
Sep 30, 2025
coremark_pro/coremark_pro_run
Outdated
| start_pcp $pcp_dir coremark-pro $pcp_cfg | ||
| start_pcp_subset | ||
|
|
||
| pmlogger -c $pcp_cfg -l $pcp_dir/pmlogger.log $pcp_dir/archive & PMLOGGER_PID=$! |
coremark_pro/coremark_pro_run
Outdated
| pcp_cfg=$TOOLS_BIN/pcp/default.cfg | ||
| pcp_dir=/tmp/pcp_coremark-pro_$(date +%Y.%m.%d-%H.%M.%S) | ||
| start_pcp $pcp_dir coremark-pro $pcp_cfg | ||
| start_pcp_subset |
kdvalin
requested changes
Sep 30, 2025
coremark_pro/coremark_pro_run
Outdated
| start_pcp $pcp_dir coremark-pro $pcp_cfg | ||
| start_pcp_subset | ||
|
|
||
| pmlogger -c $pcp_cfg -l $pcp_dir/pmlogger.log $pcp_dir/archive & PMLOGGER_PID=$! |
Member
There was a problem hiding this comment.
Remove, it should be handled by the pcp_command.inc functions
coremark_pro/coremark_pro_run
Outdated
Comment on lines
324
to
325
| kill $PMLOGGER_PID 2>/dev/null | ||
| wait $PMLOGGER_PID 2>/dev/null |
coremark_pro/coremark_pro_run
Outdated
| pcp_cfg=$TOOLS_BIN/pcp/default.cfg | ||
| pcp_dir=/tmp/pcp_coremark-pro_$(date +%Y.%m.%d-%H.%M.%S) | ||
| start_pcp $pcp_dir coremark-pro $pcp_cfg | ||
| start_pcp_subset |
Member
There was a problem hiding this comment.
Remove this, as it is handled within the iteration loop
kdvalin
added
the
group_review_lgtm
dvalinrh
previously approved these changes
Sep 30, 2025
| if [ $no_overrides -eq 0 ]; then | ||
| update_build_options | ||
| make TARGET=linux64 build | ||
| exit_out "make of test failed, exiting" 1 |
grdumas
deleted the
Transition-from-pbench-to-Performance-Co-Pilot-(PCP)
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Performance Co-Pilot (PCP) metric collection during test runs. The new PCP functionality replaces the previous Pbench implementation, which is now deprecated.
Before/After Comparison
Before: wrapper provided Pbench functionality via
--pbench.After: wrapper no longer has Pbench functionality nor CLI options. Via the
--use_pcpoption, users can chose to create a PCP archive during the test run.Clerical Stuff
This closes #45
Mention the JIRA ticket of the issue, this helps keep
everything together so we can find this PR easily.
Relates to JIRA: RPOPC-632