-
Notifications
You must be signed in to change notification settings - Fork 1
Adding in pcp metricsfor test. #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to RPOPC-772 |
|
This code solution is always reproducible. It successfully writes results to both CSV file and PCP OpenMetrics directory. |
sayalibhavsar
approved these changes
Jan 22, 2026
sayalibhavsar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Has test place the results into the pcp openmetric file
Before/After Comparison
Metrics only appeared in the csv file
Now test metrics appears in both the csv file and the openmetric file
Clerical Stuff
This closes #66
Relates to JIRA: RPOPC-772
Test Results
Command run
/home/ec2-user/workloads/coremark-wrapper/coremark/coremark_run --run_user ec2-user --home_parent /home --iterations 1 --tuned_setting tuned_none_sys_file_ --host_config "m5.xlarge" --sysname "m5.xlarge" --sys_type aws --use_pcp
CSV file
iiteration:threads:IterationsPerSec
1:4:58590.889117
1:4:59627.329193
pcp snippet
o.w.iteration o.w.running o.w.numthreads o.w.runtime o.w.throughput o.w.latency o.w.IterationsPerSec o.w.runlog
18:56:04 0.000 1.000 0.000 NaN NaN NaN NaN NaN
18:56:05 1.000 1.000 4.000 NaN NaN NaN 58590.889 1.000
18:56:06 1.000 1.000 4.000 NaN NaN NaN 58590.889 1.000
18:56:07 0.000 0.000 0.000 NaN NaN NaN NaN NaN
18:56:08 0.000 0.000 0.000 NaN NaN NaN NaN NaN
18:56:09 1.000 0.000 4.000 NaN NaN NaN 59627.329 2.000
-x output
coremark.txt