Skip to content

Conversation

@dvalinrh
Copy link
Contributor

Description

Has test place the results into the pcp openmetric file

Before/After Comparison

Metrics only appeared in the csv file

Now test metrics appears in both the csv file and the openmetric file

Clerical Stuff

This closes #66

Relates to JIRA: RPOPC-772

Test Results

Command run
/home/ec2-user/workloads/coremark-wrapper/coremark/coremark_run --run_user ec2-user --home_parent /home --iterations 1 --tuned_setting tuned_none_sys_file_ --host_config "m5.xlarge" --sysname "m5.xlarge" --sys_type aws --use_pcp

CSV file
iiteration:threads:IterationsPerSec
1:4:58590.889117
1:4:59627.329193

pcp snippet
o.w.iteration o.w.running o.w.numthreads o.w.runtime o.w.throughput o.w.latency o.w.IterationsPerSec o.w.runlog
18:56:04 0.000 1.000 0.000 NaN NaN NaN NaN NaN
18:56:05 1.000 1.000 4.000 NaN NaN NaN 58590.889 1.000
18:56:06 1.000 1.000 4.000 NaN NaN NaN 58590.889 1.000
18:56:07 0.000 0.000 0.000 NaN NaN NaN NaN NaN
18:56:08 0.000 0.000 0.000 NaN NaN NaN NaN NaN
18:56:09 1.000 0.000 4.000 NaN NaN NaN 59627.329 2.000

-x output
coremark.txt

@github-actions
Copy link

This relates to RPOPC-772

@sayalibhavsar
Copy link

This code solution is always reproducible. It successfully writes results to both CSV file and PCP OpenMetrics directory.

root@sbhavsar-thinkpadp16vgen1:~/export_results/coremark_2026.01.22-12.55.45# pminfo -a pcp_2026.01.22-12.54.33/ | grep -i openmetrics
openmetrics.control.fetch_time
openmetrics.workload.iteration
openmetrics.workload.running
openmetrics.workload.numthreads
openmetrics.workload.runtime
openmetrics.workload.throughput
openmetrics.workload.latency
openmetrics.workload.runlog
openmetrics.workload.IterationsPerSec
openmetrics.grafana.go_memstats_last_gc_since_start_time_seconds


root@sbhavsar-thinkpadp16vgen1:~/export_results/coremark_2026.01.22-12.55.45/pcp_2026.01.22-12.54.33#   pmrep -p -a . openmetrics.workload                                                                                                                                                          
          o.w.iteration  o.w.running  o.w.numthreads  o.w.runtime  o.w.throughput  o.w.latency  o.w.runlog  o.w.IterationsPerSec
                                                                                                                                
12:54:36            N/A          N/A             N/A          N/A             N/A          N/A         N/A                   N/A
12:54:37          0.000        0.000           0.000          NaN             NaN          NaN         NaN                   NaN
12:54:38          0.000        0.000           0.000          NaN             NaN          NaN         NaN                   NaN
12:54:39          0.000        1.000           0.000          NaN             NaN          NaN         NaN                   NaN
12:54:40          0.000        1.000           0.000          NaN             NaN          NaN         NaN                   NaN
12:54:41          0.000        1.000           0.000          NaN             NaN          NaN         NaN                   NaN
12:54:42          0.000        1.000           0.000          NaN             NaN          NaN         NaN                   NaN
root@sbhavsar-thinkpadp16vgen1:~/export_results/coremark_2026.01.22-12.55.45# ls -l
total 40
drwxr-xr-x. 1 root root   98 Jan 22 12:55  pcp_2026.01.22-12.54.33
-rw-r--r--. 1 root root  436 Jan 22 12:55  results_coremark.csv
-rw-r--r--. 1 root root 2395 Jan 22 12:55 'run1_iter=1_threads=16.log'
-rw-r--r--. 1 root root 6141 Jan 22 12:55  run1_summary
-rw-r--r--. 1 root root 2234 Jan 22 12:55 'run2_iter=1_threads=16.log'
-rw-r--r--. 1 root root 5661 Jan 22 12:55  run2_summary
-rw-r--r--. 1 root root    4 Jan 22 12:55  test_results_report
-rw-r--r--. 1 root root   23 Jan 22 12:55  tuned_setting
-rw-r--r--. 1 root root   14 Jan 22 12:55  version

root@sbhavsar-thinkpadp16vgen1:~/export_results/coremark_2026.01.22-12.55.45# cat results_coremark.csv 
# Test general meta start
# Test: coremark
# Results version: v1.01
# Host: sbhavsar-thinkpadp16vgen1.punetw6.csb
# Sys environ: sbhavsar-thinkpadp16vgen1.punetw6.csb
# Tuned: balanced-battery
# OS: 6.17.12-300.fc43.x86_64
# Numa nodes: 1
# CPU family: AMD Ryzen 7 PRO 7840HS w/ Radeon 780M Graphics
# Number cpus: 16
# Memory: 64420692kB
# Test general meta end
iteration:threads:IterationsPerSec
1:16:429280.507982
1:16:445454.967287


root@sbhavsar-thinkpadp16vgen1:~/export_results/coremark_2026.01.22-12.55.45#   pmrep -p -a pcp_2026.01.22-12.54.33/ openmetrics.workload.IterationsPerSec | grep -v NaN                                                                                                    
          o.w.IterationsPerSec
                              
12:54:36                   N/A
12:55:31            445454.967
12:55:32            445454.967
12:55:35            429280.508
12:55:36            429280.508

root@sbhavsar-thinkpadp16vgen1:~/export_results/coremark_2026.01.22-12.55.45#   pmrep -p -a pcp_2026.01.22-12.54.33/ openmetrics.workload | tail -6                                                                                                              
12:55:31          1.000        1.000          16.000          NaN             NaN          NaN       1.000            445454.967
12:55:32          1.000        1.000          16.000          NaN             NaN          NaN       1.000            445454.967
12:55:33          0.000        0.000           0.000          NaN             NaN          NaN         NaN                   NaN
12:55:34          0.000        0.000           0.000          NaN             NaN          NaN         NaN                   NaN
12:55:35          1.000        0.000          16.000          NaN             NaN          NaN       2.000            429280.508
12:55:36          1.000        0.000          16.000          NaN             NaN          NaN       2.000            429280.508

Copy link

@sayalibhavsar sayalibhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvalinrh dvalinrh merged commit d537114 into main Jan 23, 2026
3 of 4 checks passed
@dvalinrh dvalinrh deleted the update_pcp branch January 23, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pcp metric support

3 participants