Modify markdown formatting and file name #425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed file name to a more standard file extension for markdown README files Edited section header formatting Created code blocks
tyll
reviewed
Nov 12, 2019
tyll
left a comment
tyll
left a comment
There was a problem hiding this comment.
Thank you for your changes. They look mostly good for me. There are small issues with the bash code.
Unfortunately I cannot merge code here but I hope someone will, soon.
| clouds to build an image. The above template example was saved to a file name f12_64.tdl. | ||
|
|
||
| ```bash | ||
| $ sudo imagefactory --template f12_64.tdl --target ec2 |
There was a problem hiding this comment.
This is not valid bash code with the prompt $ included, IMHO it would be nicer to remove the prompt. Everyone who understands what it should mean can probably also deduct this from sudo being used.
| push the image into the cloud. | ||
|
|
||
| ```bash | ||
| $ sudo imagefactory --provider ec2-us-west-1 --credentials ec2_credentials.xml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed file name to a more standard file extension for markdown README files
Edited section header formatting
Created code blocks